[E2E] Chain the custom `button` command (#31196)

* Make custom `button` command chainable

* Chain `.button` directly

No need to use `.within()` anymore.
We can chain the button command directly because it now receives
the previously yielded subject.

* Fix collections bulk actions test

e2e/support/commands/ui/button.js

-Cypress.Commands.add("button", (button_name, timeout) => {
-  cy.findByRole("button", { name: button_name, timeout: timeout });
-});
+Cypress.Commands.add(
+  "button",
+  {
+    prevSubject: "optional",
+  },
+  (subject, button_name, timeout) => {
+    const config = {
+      name: button_name,
+      timeout,
+    };
+
+    if (subject) {
+      cy.wrap(subject).findByRole("button", config);
+    } else {
+      cy.findByRole("button", config);
+    }
+  },
+);

e2e/test/scenarios/collections/collections.cy.spec.js

@@ -505,6 +505,7 @@ describe("scenarios > collection defaults", () => {
 
           // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
           cy.findByText(/item(s)? selected/)
+            .parent()
             .button("Archive")
             .click();
 
@@ -522,6 +523,7 @@ describe("scenarios > collection defaults", () => {
 
           // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
           cy.findByText(/item(s)? selected/)
+            .parent()
             .button("Move")
             .click();
 

e2e/test/scenarios/custom-column/reproductions/19745-cc-nested-query-remove-expressions.cy.spec.js

@@ -104,6 +104,6 @@ function removeAllExpressions() {
 function updateQuestion() {
   cy.intercept("PUT", "/api/card/*").as("updateQuestion");
   cy.findByText("Save").click();
-  modal().within(() => cy.button("Save").click());
+  modal().button("Save").click();
   cy.wait("@updateQuestion");
 }

e2e/test/scenarios/models/reproductions/28971-filters-model-new-model.cy.spec.js

@@ -29,7 +29,7 @@ describe("issue 28971", () => {
     // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
     popover().within(() => cy.findByText("Orders").click());
     cy.button("Save").click();
-    modal().within(() => cy.button("Save").click());
+    modal().button("Save").click();
     cy.wait("@createCard");
 
     filter();

e2e/test/scenarios/organization/timelines-collection.cy.spec.js

@@ -252,7 +252,7 @@ describe("scenarios > organization > timelines > collection", () => {
       cy.findByText("Move event").click();
       // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
       cy.findByText("Releases").click();
-      getModal().within(() => cy.button("Move").click());
+      getModal().button("Move").click();
       cy.wait("@updateEvent");
       // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
       cy.findByText("RC2").should("not.exist");
@@ -284,7 +284,7 @@ describe("scenarios > organization > timelines > collection", () => {
       cy.findByText("Move event").click();
       // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
       cy.findByText("Releases").click();
-      getModal().within(() => cy.button("Move").click());
+      getModal().button("Move").click();
       cy.wait("@updateEvent");
       // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
       cy.findByText("RC2").should("not.exist");