use generic props override instead of just `title` and `onBack`

frontend/src/metabase/query_builder/components/SidebarContent.jsx

@@ -10,7 +10,6 @@ export default function SidebarContent({
   className,
   icon,
   title,
-  titleOverride,
   color,
   onBack,
   onClose,
@@ -23,9 +22,6 @@ export default function SidebarContent({
   ) : null,
   children,
 }) {
-  if (titleOverride) {
-    ({ title, onBack } = titleOverride);
-  }
   return (
     <div className={cx(className, "flex flex-column justify-between")}>
       <div className="scroll-y">

frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.jsx

@@ -6,10 +6,10 @@ import visualizations from "metabase/visualizations";
 import SidebarContent from "metabase/query_builder/components/SidebarContent";
 
 export default class ChartSettingsSidebar extends React.Component {
-  state = { isSidebarTitleHidden: false };
+  state = { sidebarPropsOverride: undefined };
 
-  setSidebarTitleOverride = sidebarTitleOverride =>
-    this.setState({ sidebarTitleOverride });
+  setSidebarPropsOverride = sidebarPropsOverride =>
+    this.setState({ sidebarPropsOverride });
 
   render() {
     const {
@@ -21,7 +21,7 @@ export default class ChartSettingsSidebar extends React.Component {
       onClose,
       onOpenChartType,
     } = this.props;
-    const { sidebarTitleOverride } = this.state;
+    const { sidebarPropsOverride } = this.state;
     return (
       result && (
         <SidebarContent
@@ -29,7 +29,7 @@ export default class ChartSettingsSidebar extends React.Component {
           title={t`${visualizations.get(question.display()).uiName} options`}
           onDone={onClose}
           onBack={onOpenChartType}
-          titleOverride={sidebarTitleOverride}
+          {...sidebarPropsOverride || {}}
         >
           <ChartSettings
             question={question}
@@ -44,7 +44,7 @@ export default class ChartSettingsSidebar extends React.Component {
             onClose={onClose}
             noPreview
             initial={initialChartSetting}
-            setSidebarTitleOverride={this.setSidebarTitleOverride}
+            setSidebarPropsOverride={this.setSidebarPropsOverride}
           />
         </SidebarContent>
       )

frontend/src/metabase/visualizations/components/ChartSettings.jsx

@@ -141,7 +141,7 @@ class ChartSettings extends Component {
       addField,
       noPreview,
       children,
-      setSidebarTitleOverride,
+      setSidebarPropsOverride,
     } = this.props;
     const { currentWidget } = this.state;
 
@@ -214,7 +214,7 @@ class ChartSettings extends Component {
         key={`${widget.id}`}
         {...widget}
         {...extraWidgetProps}
-        setSidebarTitleOverride={setSidebarTitleOverride}
+        setSidebarPropsOverride={setSidebarPropsOverride}
       />
     ));
 

frontend/src/metabase/visualizations/components/settings/ChartNestedSettingColumns.jsx

@@ -37,13 +37,13 @@ export default class ChartNestedSettingColumns extends React.Component {
 class ColumnWidgets extends React.Component {
   componentDidMount() {
     const {
-      setSidebarTitleOverride,
+      setSidebarPropsOverride,
       onChangeEditingObject,
       object,
     } = this.props;
 
-    if (setSidebarTitleOverride) {
-      setSidebarTitleOverride({
+    if (setSidebarPropsOverride) {
+      setSidebarPropsOverride({
         title: displayNameForColumn(object),
         onBack: () => onChangeEditingObject(),
       });
@@ -51,9 +51,9 @@ class ColumnWidgets extends React.Component {
   }
 
   componentWillUnmount() {
-    const { setSidebarTitleOverride } = this.props;
-    if (setSidebarTitleOverride) {
-      setSidebarTitleOverride(undefined);
+    const { setSidebarPropsOverride } = this.props;
+    if (setSidebarPropsOverride) {
+      setSidebarPropsOverride(undefined);
     }
   }