Skip to content
Snippets Groups Projects
Unverified Commit d3c78b60 authored by metamben's avatar metamben Committed by GitHub
Browse files

Distinguish different arities of aggregation-clause (#38726)

Fixes #37782.
parent a0273af7
No related branches found
No related tags found
No related merge requests found
......@@ -156,9 +156,7 @@ describe("Reference utils.js", () => {
expect(question).toEqual(getNewQuestion());
});
// Unskip when this is fixed: https://github.com/metabase/metabase/issues/37782
// eslint-disable-next-line jest/no-disabled-tests
it.skip("should generate correct question for table counts", () => {
it("should generate correct question for table counts", () => {
const question = getQuestion({
dbId,
tableId,
......@@ -188,9 +186,7 @@ describe("Reference utils.js", () => {
);
});
// Unskip when this is fixed: https://github.com/metabase/metabase/issues/37782
// eslint-disable-next-line jest/no-disabled-tests
it.skip("should generate correct question for field group by bar chart", () => {
it("should generate correct question for field group by bar chart", () => {
const question = getQuestion({
dbId,
tableId,
......@@ -209,9 +205,7 @@ describe("Reference utils.js", () => {
);
});
// Unskip when this is fixed: https://github.com/metabase/metabase/issues/37782
// eslint-disable-next-line jest/no-disabled-tests
it.skip("should generate correct question for field group by pie chart", () => {
it("should generate correct question for field group by pie chart", () => {
const question = getQuestion({
dbId,
tableId,
......@@ -277,9 +271,7 @@ describe("Reference utils.js", () => {
);
});
// Unskip when this is fixed: https://github.com/metabase/metabase/issues/37782
// eslint-disable-next-line jest/no-disabled-tests
it.skip("should generate correct question for segment counts", () => {
it("should generate correct question for segment counts", () => {
const question = getQuestion({
dbId,
tableId,
......
......@@ -467,10 +467,10 @@
a `column`.
For aggregations requiring an argument `column` is mandatory, otherwise
it is optional."
([aggregation-operator]
(lib.core/aggregation-clause aggregation-operator))
([aggregation-operator column]
(lib.core/aggregation-clause aggregation-operator column)))
[aggregation-operator column]
(if (undefined? column)
(lib.core/aggregation-clause aggregation-operator)
(lib.core/aggregation-clause aggregation-operator column)))
(defn ^:export available-aggregation-operators
"Get the available aggregation operators for the stage with `stage-number` of
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment