-
- Downloads
Add snowplow events for embedding setup flow (#37617)
* Add snowplow events for embedding setup flow * Fix dashboard model tests * Fix dashboard tests * Fix card tests * Fix dashboard API tests * Fix type error * Implement analytics 2/7 1. public_link_copied 2. public_link_removed * Fix snowplow schema enum Removing null as we don't seem to put `null` in `enum` * Complete the embed_flow snowplow schema * Modify `initial_published_at` to not be overridden * Implement analytics 4/7 1. public_link_copied 2. public_link_removed 3. public_embed_code_copied 4. static_embed_published 5. static_embed_unpublished * Prevent accidental ESLint log in Cypress * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues` We were mixing the type before, as the former one are the type of the setting values, not the actual values for the parameters. * Fix dashboard and card types * Fix `params` count for `static_embed_published` event * fixup! Prevent accidental ESLint log in Cypress * Fix ESlint from the result of upgrading ESLint package * Fix Snowplow schema enum to include null * Fully implement `static_embed_code_copied` * Finish embed_flow snowplow* Fix unit tests because markup change * Fix E2E tests * Fix E2E CI failure Apparently using `.realClick()` on copy button could fail locally, but pass on CI and vice-versa. I couldn't replicate this all the time. I'm not sure why it would fail locally. * Fix copy to clipboard not working on CI * Improve test readability * Remove extra test-id * Fix refactor `*CodeOptionId` * Restrict Snowplow schema * Revert unnecessary change * Apply Cal's suggestions for BE improvements Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * Update src/metabase/util/embed.clj Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * Fix backend linter error, hopefully. --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Nicolò Pretto <info@npretto.com>
Showing
- e2e/support/helpers/e2e-snowplow-helpers.js 48 additions, 1 deletione2e/support/helpers/e2e-snowplow-helpers.js
- e2e/support/helpers/e2e-ui-elements-helpers.js 5 additions, 0 deletionse2e/support/helpers/e2e-ui-elements-helpers.js
- e2e/test/scenarios/embedding/embedding-downloads-questions.cy.spec.js 1 addition, 1 deletion...narios/embedding/embedding-downloads-questions.cy.spec.js
- e2e/test/scenarios/embedding/embedding-smoketests.cy.spec.js 3 additions, 1 deletione2e/test/scenarios/embedding/embedding-smoketests.cy.spec.js
- e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js 545 additions, 11 deletions...s/sharing/public-sharing-embed-button-behavior.cy.spec.js
- frontend/src/metabase-types/api/card.ts 3 additions, 0 deletionsfrontend/src/metabase-types/api/card.ts
- frontend/src/metabase-types/api/dashboard.ts 4 additions, 1 deletionfrontend/src/metabase-types/api/dashboard.ts
- frontend/src/metabase-types/api/mocks/card.ts 3 additions, 0 deletionsfrontend/src/metabase-types/api/mocks/card.ts
- frontend/src/metabase-types/api/mocks/dashboard.ts 3 additions, 0 deletionsfrontend/src/metabase-types/api/mocks/dashboard.ts
- frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx 3 additions, 0 deletions...QueryActionContextProvider/QueryActionContextProvider.tsx
- frontend/src/metabase/dashboard/actions/sharing.ts 4 additions, 1 deletionfrontend/src/metabase/dashboard/actions/sharing.ts
- frontend/src/metabase/dashboard/components/DashboardTabs/test-utils.ts 3 additions, 0 deletions...metabase/dashboard/components/DashboardTabs/test-utils.ts
- frontend/src/metabase/dashboard/components/PublicLinkPopover/DashboardPublicLinkPopover.tsx 15 additions, 0 deletions...mponents/PublicLinkPopover/DashboardPublicLinkPopover.tsx
- frontend/src/metabase/dashboard/components/PublicLinkPopover/PublicLinkCopyPanel.tsx 4 additions, 1 deletion...oard/components/PublicLinkPopover/PublicLinkCopyPanel.tsx
- frontend/src/metabase/dashboard/components/PublicLinkPopover/PublicLinkPopover.tsx 3 additions, 0 deletions...hboard/components/PublicLinkPopover/PublicLinkPopover.tsx
- frontend/src/metabase/dashboard/components/PublicLinkPopover/QuestionPublicLinkPopover.tsx 16 additions, 0 deletions...omponents/PublicLinkPopover/QuestionPublicLinkPopover.tsx
- frontend/src/metabase/dashboard/reducers.js 5 additions, 5 deletionsfrontend/src/metabase/dashboard/reducers.js
- frontend/src/metabase/public/components/EmbedModal/SelectEmbedTypePane/SelectEmbedTypePane.tsx 17 additions, 0 deletions...ts/EmbedModal/SelectEmbedTypePane/SelectEmbedTypePane.tsx
- frontend/src/metabase/public/components/EmbedModal/SelectEmbedTypePane/SharingPaneButton/SharingPaneButton.tsx 7 additions, 1 deletion...lectEmbedTypePane/SharingPaneButton/SharingPaneButton.tsx
- frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/AppearanceSettings.tsx 27 additions, 11 deletions...ts/EmbedModal/StaticEmbedSetupPane/AppearanceSettings.tsx
Loading
Please register or sign in to comment