Skip to content
Snippets Groups Projects
Unverified Commit d43863a2 authored by Oisin Coveney's avatar Oisin Coveney Committed by GitHub
Browse files

Add snowplow events for embedding setup flow (#37617)

* Add snowplow events for embedding setup flow

* Fix dashboard model tests

* Fix dashboard tests

* Fix card tests

* Fix dashboard API tests

* Fix type error

* Implement analytics 2/7

1. public_link_copied
2. public_link_removed

* Fix snowplow schema enum

Removing null as we don't seem to put `null` in `enum`

* Complete the embed_flow snowplow schema

* Modify `initial_published_at` to not be overridden

* Implement analytics 4/7

1. public_link_copied
2. public_link_removed
3. public_embed_code_copied
4. static_embed_published
5. static_embed_unpublished

* Prevent accidental ESLint log in Cypress

* Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues`

We were mixing the type before, as the former one are the type of the
setting values, not the actual values for the parameters.

* Fix dashboard and card types

* Fix `params` count for `static_embed_published` event

* fixup! Prevent accidental ESLint log in Cypress

* Fix ESlint from the result of upgrading ESLint package

* Fix Snowplow schema enum to include null

* Fully implement `static_embed_code_copied`

* Finish embed_flow snowplow :tada:



* Fix unit tests because markup change

* Fix E2E tests

* Fix E2E CI failure

Apparently using `.realClick()` on copy button could fail locally,
but pass on CI and vice-versa. I couldn't replicate this all the time.

I'm not sure why it would fail locally.

* Fix copy to clipboard not working on CI

* Improve test readability

* Remove extra test-id

* Fix refactor `*CodeOptionId`

* Restrict Snowplow schema

* Revert unnecessary change

* Apply Cal's suggestions for BE improvements

Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>

* Update src/metabase/util/embed.clj

Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>

* Fix backend linter error, hopefully.

---------

Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
parent 48119c60
No related branches found
No related tags found
No related merge requests found
Showing
with 719 additions and 34 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment