[Feature] Dashboard Tab basic functionality (#30177)
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
Showing
- .clj-kondo/config.edn 2 additions, 0 deletions.clj-kondo/config.edn
- e2e/snapshot-creators/default.cy.snap.js 5 additions, 16 deletionse2e/snapshot-creators/default.cy.snap.js
- e2e/support/commands/api/composite/createNativeQuestionAndDashboard.js 1 addition, 1 deletion...ommands/api/composite/createNativeQuestionAndDashboard.js
- e2e/support/commands/api/composite/createQuestionAndAddToDashboard.js 1 addition, 1 deletion...commands/api/composite/createQuestionAndAddToDashboard.js
- e2e/support/commands/api/composite/createQuestionAndDashboard.js 1 addition, 1 deletion...port/commands/api/composite/createQuestionAndDashboard.js
- e2e/support/helpers/e2e-dashboard-helpers.js 7 additions, 2 deletionse2e/support/helpers/e2e-dashboard-helpers.js
- e2e/test/scenarios/collections/revision-history.cy.spec.js 3 additions, 2 deletionse2e/test/scenarios/collections/revision-history.cy.spec.js
- e2e/test/scenarios/dashboard/dashboard.cy.spec.js 4 additions, 3 deletionse2e/test/scenarios/dashboard/dashboard.cy.spec.js
- e2e/test/scenarios/dashboard/tabs.cy.spec.js 35 additions, 0 deletionse2e/test/scenarios/dashboard/tabs.cy.spec.js
- e2e/test/scenarios/models/models.cy.spec.js 2 additions, 1 deletione2e/test/scenarios/models/models.cy.spec.js
- e2e/test/scenarios/onboarding/home/activity-page.cy.spec.js 2 additions, 2 deletionse2e/test/scenarios/onboarding/home/activity-page.cy.spec.js
- enterprise/backend/src/metabase_enterprise/serialization/v2/seed_entity_ids.clj 0 additions, 1 deletion.../metabase_enterprise/serialization/v2/seed_entity_ids.clj
- enterprise/backend/test/metabase_enterprise/sandbox/api/dashboard_test.clj 1 addition, 1 deletion...d/test/metabase_enterprise/sandbox/api/dashboard_test.clj
- frontend/src/metabase-types/api/dashboard.ts 14 additions, 0 deletionsfrontend/src/metabase-types/api/dashboard.ts
- frontend/src/metabase-types/store/dashboard.ts 23 additions, 2 deletionsfrontend/src/metabase-types/store/dashboard.ts
- frontend/src/metabase-types/store/mocks/dashboard.ts 7 additions, 0 deletionsfrontend/src/metabase-types/store/mocks/dashboard.ts
- frontend/src/metabase/actions/containers/ActionParametersInputForm/ActionParametersInputForm.tsx 2 additions, 1 deletion...s/ActionParametersInputForm/ActionParametersInputForm.tsx
- frontend/src/metabase/components/Timeline/Timeline.jsx 2 additions, 0 deletionsfrontend/src/metabase/components/Timeline/Timeline.jsx
- frontend/src/metabase/core/components/TabButton/TabButton.tsx 24 additions, 24 deletions...tend/src/metabase/core/components/TabButton/TabButton.tsx
- frontend/src/metabase/core/components/TabButton/TabButton.unit.spec.tsx 2 additions, 2 deletions...etabase/core/components/TabButton/TabButton.unit.spec.tsx
Loading
Please register or sign in to comment