Remove silly showScrollbars thing and always just use 'scroll-show' class with 'overflow-y: auto'

frontend/src/admin/metadata/components/MetadataField.jsx

@@ -130,7 +130,6 @@ export default class MetadataField extends Component {
                                     value={_.find(MetabaseCore.field_special_types, (type) => type.id === this.props.field.special_type)}
                                     options={MetabaseCore.field_special_types}
                                     onChange={this.onSpecialTypeChange}
-                                    showScrollbars={true}
                                 />
                                 {targetSelect}
                             </div>

frontend/src/components/ColumnarSelector.jsx

@@ -6,8 +6,7 @@ import cx from "classnames";
 
 export default class ColumnarSelector extends Component {
     static propTypes = {
-        columns: PropTypes.array.isRequired,
-        showScrollbars: PropTypes.bool
+        columns: PropTypes.array.isRequired
     };
 
     render() {
@@ -57,7 +56,7 @@ export default class ColumnarSelector extends Component {
             }
 
             return (
-                <div key={columnIndex} className={cx("ColumnarSelector-column", { "scroll-show": this.props.showScrollbars })}>
+                <div key={columnIndex} className="ColumnarSelector-column scroll-y scroll-show">
                     {sectionElements}
                 </div>
             );

frontend/src/components/Select.jsx

@@ -11,8 +11,7 @@ export default class Select extends Component {
         placeholder: PropTypes.string,
         onChange: PropTypes.func,
         optionNameFn: PropTypes.func,
-        optionValueFn: PropTypes.func,
-        showScrollbars: PropTypes.bool
+        optionValueFn: PropTypes.func
     };
 
     static defaultProps = {
@@ -64,7 +63,6 @@ export default class Select extends Component {
                                 triggerClasses={"AdminSelect " + (this.props.className || "")}>
                 <ColumnarSelector
                     columns={columns}
-                    showScrollbars={this.props.showScrollbars}
                 />
             </PopoverWithTrigger>
         );

frontend/src/components/columnar_selector/columnar_selector.css

@@ -9,7 +9,6 @@
     min-width: 180px;
     min-height: 300px;
     max-height: 340px;
-    overflow-y: auto;
     flex: 1;
 }