-
- Downloads
Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys (#47489)
* Move query-processor.util/remove-lib-uuids to lib.schema.util This function will soon be needed in lib.schema.util in order to implement distinct order-by clause schema checking. This function feels like it should live in lib.util instead of lib.schema.util, but that would create the following circular import dependency since lib.util indirectly requires stuff from lib.schema.util: lib.schema.util -> lib.util -> lib.schema.util * Don't create queries with duplicate order-bys in remove_replace_test.cljc Otherwise, theses tests would fail soon when we add update the order-by schema to reject duplicates. * Declare lib.order-by/order-bys to return ::lib.schema.order-by/order-bys Previously it inlined the schema instead. * Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys Fixes: 39384
Showing
- src/metabase/lib/order_by.cljc 1 addition, 1 deletionsrc/metabase/lib/order_by.cljc
- src/metabase/lib/schema/order_by.cljc 2 additions, 2 deletionssrc/metabase/lib/schema/order_by.cljc
- src/metabase/lib/schema/util.cljc 26 additions, 0 deletionssrc/metabase/lib/schema/util.cljc
- src/metabase/query_processor/util.clj 2 additions, 12 deletionssrc/metabase/query_processor/util.clj
- test/metabase/lib/order_by_test.cljc 51 additions, 0 deletionstest/metabase/lib/order_by_test.cljc
- test/metabase/lib/remove_replace_test.cljc 2 additions, 2 deletionstest/metabase/lib/remove_replace_test.cljc
- test/metabase/lib/schema/order_by_test.cljc 64 additions, 0 deletionstest/metabase/lib/schema/order_by_test.cljc
- test/metabase/lib/schema/util_test.cljc 111 additions, 1 deletiontest/metabase/lib/schema/util_test.cljc
- test/metabase/lib/schema_test.cljc 48 additions, 0 deletionstest/metabase/lib/schema_test.cljc
- test/metabase/query_processor/middleware/normalize_query_test.clj 24 additions, 0 deletions...abase/query_processor/middleware/normalize_query_test.clj
- test/metabase/query_processor_test/order_by_test.clj 24 additions, 0 deletionstest/metabase/query_processor_test/order_by_test.clj
Loading
Please register or sign in to comment