-
- Downloads
[MLv2] Fix template-tags snippet-id (#33902)
* [MLv2] Fix template-tags snippet-id Looking at this bug I found there were a couple problems that the converters were not properly handling. First, the conversion to js was copying snake case to kebab case instead of renaming. Second the conversion to clojure was not picking up kebab case keys but using the snake case keys. So I dropped the TemplateTag encoder and decoder and went forward with js->clj and clj->js since the only tricky part was keeping the tag names as strings and keeping the :type as keyword. * Address review comments
Showing
- src/metabase/lib/core.cljc 0 additions, 2 deletionssrc/metabase/lib/core.cljc
- src/metabase/lib/js.cljs 9 additions, 10 deletionssrc/metabase/lib/js.cljs
- src/metabase/lib/native.cljc 3 additions, 12 deletionssrc/metabase/lib/native.cljc
- test/metabase/lib/js_test.cljs 20 additions, 1 deletiontest/metabase/lib/js_test.cljs
- test/metabase/lib/native_test.cljc 9 additions, 42 deletionstest/metabase/lib/native_test.cljc
Loading
Please register or sign in to comment