Do not return zoom/pk/fk-details drills for null cell values (#36385)

src/metabase/lib/drill_thru/object_details.cljc

@@ -19,14 +19,17 @@
     (cond
       (and (lib.types.isa/primary-key? column)
            many-pks?
-           mbql-stage?)
+           mbql-stage?
+           (not= value :null))
       (assoc base :type :drill-thru/pk)
 
       ;; TODO: Figure out clicked.extraData and the dashboard flow.
-      (lib.types.isa/primary-key? column)
+      (and (lib.types.isa/primary-key? column)
+           (not= value :null))
       (assoc base :type :drill-thru/zoom)
 
-      (lib.types.isa/foreign-key? column)
+      (and (lib.types.isa/foreign-key? column)
+           (not= value :null))
       (assoc base :type :drill-thru/fk-details)
 
       (and (not many-pks?)

test/metabase/lib/drill_thru/fk_details_test.cljc

@@ -118,3 +118,15 @@
                                           [:field {} (meta/id :people :id)]
                                           1]]}]}
                     (lib/drill-thru query -1 fk-details-drill)))))))))
+
+(deftest ^:parallel do-not-return-fk-details-for-nil-test
+  (testing "do not return fk-details drills for nil cell values (#36133)"
+    (let [query   (lib/query meta/metadata-provider (meta/table-metadata :orders))
+          context {:column     (meta/field-metadata :orders :product-id)
+                   :column-ref (lib/ref (meta/field-metadata :orders :product-id))
+                   :value      :null
+                   :row        [{:column     (meta/field-metadata :orders :product-id)
+                                 :column-ref (lib/ref (meta/field-metadata :orders :product-id))
+                                 :value      nil}]}]
+      (is (not (m/find-first #(= (:type %) :drill-thru/fk-details)
+                             (lib/available-drill-thrus query -1 context)))))))

test/metabase/lib/drill_thru/pk_test.cljc

+(ns metabase.lib.drill-thru.pk-test
+  (:require
+   [clojure.test :refer [deftest is testing]]
+   [medley.core :as m]
+   [metabase.lib.core :as lib]
+   [metabase.lib.test-metadata :as meta]
+   [metabase.lib.test-util :as lib.tu]))
+
+(deftest ^:parallel do-not-return-pk-for-nil-test
+  (testing "do not return pk drills for nil cell values (#36126)"
+    ;; simulate a table with multiple PK columns: mark orders.product-id as a PK column
+    (let [metadata-provider (lib.tu/merged-mock-metadata-provider
+                             meta/metadata-provider
+                             {:fields [{:id            (meta/id :orders :product-id)
+                                        :semantic-type :type/PK}]})
+          query             (lib/query metadata-provider (meta/table-metadata :orders))
+          context           {:column     (meta/field-metadata :orders :id)
+                             :column-ref (lib/ref (meta/field-metadata :orders :id))
+                             :value      :null
+                             :row        [{:column     (meta/field-metadata :orders :id)
+                                           :column-ref (lib/ref (meta/field-metadata :orders :id))
+                                           :value      nil}]}]
+      (is (not (m/find-first #(= (:type %) :drill-thru/pk)
+                             (lib/available-drill-thrus query -1 context)))))))

test/metabase/lib/drill_thru/zoom_test.cljc

 (ns metabase.lib.drill-thru.zoom-test
   (:require
-   [clojure.test :refer [deftest]]
-   [metabase.lib.drill-thru.test-util :as lib.drill-thru.tu]))
+   [clojure.test :refer [deftest is testing]]
+   [medley.core :as m]
+   [metabase.lib.core :as lib]
+   [metabase.lib.drill-thru.test-util :as lib.drill-thru.tu]
+   [metabase.lib.test-metadata :as meta]))
 
 (deftest ^:parallel returns-zoom-test-1
   (lib.drill-thru.tu/test-returns-drill
@@ -52,3 +55,15 @@
     :expected    {:type      :drill-thru/zoom
                   :object-id (get-in lib.drill-thru.tu/test-queries ["ORDERS" :unaggregated :row "ID"])
                   :many-pks? false}}))
+
+(deftest ^:parallel do-not-return-zoom-for-nil-test
+  (testing "do not return zoom drills for nil cell values (#36130)"
+    (let [query   (lib/query meta/metadata-provider (meta/table-metadata :orders))
+          context {:column     (meta/field-metadata :orders :id)
+                   :column-ref (lib/ref (meta/field-metadata :orders :id))
+                   :value      :null
+                   :row        [{:column     (meta/field-metadata :orders :id)
+                                 :column-ref (lib/ref (meta/field-metadata :orders :id))
+                                 :value      nil}]}]
+      (is (not (m/find-first #(= (:type %) :drill-thru/zoom)
+                             (lib/available-drill-thrus query -1 context)))))))