Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
d9f29d49
Unverified
Commit
d9f29d49
authored
5 years ago
by
Paul Rosenzweig
Committed by
GitHub
5 years ago
Browse files
Options
Downloads
Patches
Plain Diff
fetch field values for multiple field_ids (#10341)
parent
c5c2da5b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/parameters/components/ParameterValueWidget.jsx
+12
-10
12 additions, 10 deletions
...c/metabase/parameters/components/ParameterValueWidget.jsx
with
12 additions
and
10 deletions
frontend/src/metabase/parameters/components/ParameterValueWidget.jsx
+
12
−
10
View file @
d9f29d49
...
...
@@ -84,7 +84,8 @@ export default class ParameterValueWidget extends Component {
className
:
""
,
};
getField
()
{
// this method assumes the parameter is associated with only one field
getSingleField
()
{
const
{
parameter
,
metadata
}
=
this
.
props
;
return
parameter
.
field_id
!=
null
?
metadata
.
fields
[
parameter
.
field_id
]
...
...
@@ -95,7 +96,7 @@ export default class ParameterValueWidget extends Component {
const
{
parameter
,
values
}
=
this
.
props
;
if
(
DATE_WIDGETS
[
parameter
.
type
])
{
return
DATE_WIDGETS
[
parameter
.
type
];
}
else
if
(
this
.
getField
())
{
}
else
if
(
this
.
get
Single
Field
())
{
return
ParameterFieldWidget
;
}
else
if
(
values
&&
values
.
length
>
0
)
{
return
CategoryWidget
;
...
...
@@ -114,19 +115,20 @@ export default class ParameterValueWidget extends Component {
}
}
fieldIds
({
parameter
:
{
field_id
,
field_ids
=
[]
}
})
{
return
field_id
?
[
field_id
]
:
field_ids
;
}
componentWillReceiveProps
(
nextProps
)
{
if
(
nextProps
.
parameter
.
field_id
!=
null
&&
nextProps
.
parameter
.
field_id
!==
this
.
props
.
parameter
.
field_id
)
{
if
(
!
_
.
isEqual
(
this
.
fieldIds
(
this
.
props
),
this
.
fieldIds
(
nextProps
)))
{
this
.
updateFieldValues
(
nextProps
);
}
}
updateFieldValues
(
props
)
{
if
(
props
.
parameter
.
field_id
!=
null
)
{
props
.
fetchField
(
props
.
parameter
.
field_
id
);
props
.
fetchFieldValues
(
props
.
parameter
.
field_
id
);
for
(
const
id
of
this
.
fieldIds
(
props
)
)
{
props
.
fetchField
(
id
);
props
.
fetchFieldValues
(
id
);
}
}
...
...
@@ -229,7 +231,7 @@ export default class ParameterValueWidget extends Component {
placeholder
=
{
placeholder
}
value
=
{
value
}
values
=
{
values
}
field
=
{
this
.
getField
()
}
field
=
{
this
.
get
Single
Field
()
}
setValue
=
{
setValue
}
isEditing
=
{
isEditing
}
commitImmediately
=
{
commitImmediately
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment