Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
db182076
Unverified
Commit
db182076
authored
1 year ago
by
Cal Herries
Committed by
GitHub
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
Add issue links for some TODOs (#40056)
parent
7c2adc7c
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/driver/sql_jdbc/execute.clj
+3
-4
3 additions, 4 deletions
src/metabase/driver/sql_jdbc/execute.clj
with
3 additions
and
4 deletions
src/metabase/driver/sql_jdbc/execute.clj
+
3
−
4
View file @
db182076
...
...
@@ -124,7 +124,7 @@
;; TODO -- maybe like [[do-with-connection-with-options]] we should replace [[prepared-statment]] and [[statement]]
;; with `do-with-prepared-statement` and `do-with-statement` methods -- that way you can't accidentally forget to wrap
;; things in a `try-catch` and call `.close`
;; things in a `try-catch` and call `.close`
(metabase#40010)
(
defmulti
^
PreparedStatement
prepared-statement
"Create a PreparedStatement with `sql` query, and set any `params`. You shouldn't need to override the default
...
...
@@ -230,7 +230,7 @@
metabase-enterprise.advanced-permissions.driver.impersonation
[
_
_
_
])
;; TODO - since we're not running the queries in a transaction, does this make any difference at all?
;; TODO - since we're not running the queries in a transaction, does this make any difference at all?
(metabase#40012)
(
defn
set-best-transaction-level!
"Set the connection transaction isolation level to the least-locking level supported by the DB. See
https://docs.oracle.com/cd/E19830-01/819-4721/beamv/index.html for an explanation of these levels."
...
...
@@ -360,11 +360,10 @@
;; If this is (supposedly) a read-only connection, we would prefer enable auto-commit
;; so this IS NOT ran inside of a transaction, but without transaction the read-only
;; flag has no effect for most of the drivers.
;; TODO Enable auto-commit after having communicated this change in behvaior to our users.
;;
;; TODO -- for `write?` connections, we should probably disable autoCommit and then manually call `.commit` at after
;; `f`... we need to check and make sure that won't mess anything up, since some existing code is already doing it
;; manually.
;; manually.
(metabase#40014)
(
when-not
write?
(
try
(
log/trace
(
pr-str
'
(
.setAutoCommit
conn
true
)))
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment