-
- Downloads
Add custom warning message when leaving creating a model (#34527)
* Update isNavigationAllowed logic to prevent new model creation * Rename tests * Add routes for model creation * Allow null card in setup * Add test case for creating models in isNavigationAllowed * Add simple model creation test * Add workaround for metabase#34523 * Remove "Discard changes?" confirmation modal when creating a model - use a single "Cancel" button - remove custom cancel edit warning * Update e2e test * Remove redundant function bodies * Bring back unsaved changes warning on cancel click when editing a model * Add beforeunload event test for creating models * Fix unit test * Fix unit test and isNavigationAllowed * Use regexp * Add notebook prefix * Drop mock prefix * Use it.each * Use it.each * Use it.each * Use it.each * Use it.each * Use it.each * Refactor isNavigationAllowed * Remove identifier * Update comment * Add a test for the cancel button * Rename /home route to / so that redirection after cancelling creating a model works * Add a test case for saving a new model * Avoid using fetchMock directly in QueryBuilder unit tests * Remove setupCollectionsEndpointsByIds in favor of setupCollectionByIdEndpoint * Remove default value for card parameter
Showing
- e2e/test/scenarios/dashboard/dashboard.cy.spec.js 1 addition, 3 deletionse2e/test/scenarios/dashboard/dashboard.cy.spec.js
- e2e/test/scenarios/models/create.cy.spec.js 2 additions, 4 deletionse2e/test/scenarios/models/create.cy.spec.js
- e2e/test/scenarios/models/models-metadata.cy.spec.js 1 addition, 3 deletionse2e/test/scenarios/models/models-metadata.cy.spec.js
- e2e/test/scenarios/models/models-query-editor.cy.spec.js 2 additions, 6 deletionse2e/test/scenarios/models/models-query-editor.cy.spec.js
- e2e/test/scenarios/permissions/admin-permissions.cy.spec.js 2 additions, 6 deletionse2e/test/scenarios/permissions/admin-permissions.cy.spec.js
- e2e/test/scenarios/question/settings.cy.spec.js 1 addition, 3 deletionse2e/test/scenarios/question/settings.cy.spec.js
- frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditor.jsx 14 additions, 22 deletions.../query_builder/components/DatasetEditor/DatasetEditor.jsx
- frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx 128 additions, 18 deletions...abase/query_builder/containers/QueryBuilder.unit.spec.tsx
- frontend/src/metabase/query_builder/utils.ts 14 additions, 11 deletionsfrontend/src/metabase/query_builder/utils.ts
- frontend/src/metabase/query_builder/utils.unit.spec.ts 180 additions, 107 deletionsfrontend/src/metabase/query_builder/utils.unit.spec.ts
- frontend/test/__support__/server-mocks/card.ts 9 additions, 3 deletionsfrontend/test/__support__/server-mocks/card.ts
Loading
Please register or sign in to comment