-
- Downloads
Use metabase-lib v2 to manage limit in the notebook editor (#29618)
* Move `LimitStep` to its own directory * Add unit-tests to `LimitStep` * Clean up `LimitStep` and convert to TypeScript * Include MLv2 query instance to notebook steps * Implement notebook update with MLv2 query * Update v2 `limit` wrapper signatures * Add v2 query to `updateQuery` type * Use MLv2 to manage limit in the notebook editor * Extend notebook step's helper functions for MLv2 * Use MLv2 in limit step helpers * Fix `topLevelQuery` generated from the wrong place * Respect query staging for `revert` step
Showing
- frontend/src/metabase-lib/limit.ts 13 additions, 7 deletionsfrontend/src/metabase-lib/limit.ts
- frontend/src/metabase/query_builder/components/LimitInput.tsx 12 additions, 1 deletion...tend/src/metabase/query_builder/components/LimitInput.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookStep/NotebookStep.tsx 10 additions, 3 deletions...builder/components/notebook/NotebookStep/NotebookStep.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookSteps/NotebookSteps.tsx 20 additions, 8 deletions...ilder/components/notebook/NotebookSteps/NotebookSteps.tsx
- frontend/src/metabase/query_builder/components/notebook/lib/steps.ts 39 additions, 10 deletions...c/metabase/query_builder/components/notebook/lib/steps.ts
- frontend/src/metabase/query_builder/components/notebook/steps/ExpressionStep.unit.spec.tsx 7 additions, 4 deletions...er/components/notebook/steps/ExpressionStep.unit.spec.tsx
- frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.jsx 2 additions, 0 deletions...base/query_builder/components/notebook/steps/JoinStep.jsx
- frontend/src/metabase/query_builder/components/notebook/steps/LimitStep/LimitStep.tsx 40 additions, 0 deletions...builder/components/notebook/steps/LimitStep/LimitStep.tsx
- frontend/src/metabase/query_builder/components/notebook/steps/LimitStep/LimitStep.unit.spec.tsx 86 additions, 0 deletions...mponents/notebook/steps/LimitStep/LimitStep.unit.spec.tsx
- frontend/src/metabase/query_builder/components/notebook/steps/LimitStep/index.ts 1 addition, 0 deletions...uery_builder/components/notebook/steps/LimitStep/index.ts
- frontend/src/metabase/query_builder/components/notebook/test-utils.ts 2 additions, 0 deletions.../metabase/query_builder/components/notebook/test-utils.ts
- frontend/src/metabase/query_builder/components/notebook/types.ts 7 additions, 2 deletions...d/src/metabase/query_builder/components/notebook/types.ts
Loading
Please register or sign in to comment