Remove model filters from x-rays (#37647)

e2e/test/scenarios/dashboard/reproductions/31697-question-xray-segment.cy.spec.js

@@ -48,7 +48,6 @@ describe("issue 31697", () => {
 
     cy.findByRole("main").within(() => {
       cy.findByText(/A closer look at number of Orders/).should("be.visible");
-      cy.findByText("Orders segment").should("be.visible");
     });
   });
 });

frontend/src/metabase/dashboard/containers/AutomaticDashboardApp.jsx

@@ -14,7 +14,6 @@ import ActionButton from "metabase/components/ActionButton";
 import Button from "metabase/core/components/Button";
 import Card from "metabase/components/Card";
 import { Icon } from "metabase/ui";
-import { Filter } from "metabase/admin/datamodel/components/Filter";
 import Link from "metabase/core/components/Link";
 import Tooltip from "metabase/core/components/Tooltip";
 
@@ -30,9 +29,6 @@ import * as Urls from "metabase/lib/urls";
 import * as MetabaseAnalytics from "metabase/lib/analytics";
 import { color } from "metabase/lib/colors";
 import { getValuePopulatedParameters } from "metabase-lib/parameters/utils/parameter-values";
-import * as Q from "metabase-lib/queries/utils/query";
-import { getFilterDimension } from "metabase-lib/queries/utils/dimension";
-import { isSegment } from "metabase-lib/queries/utils/filter";
 
 import { DashboardTabs } from "../components/DashboardTabs";
 import {
@@ -134,12 +130,6 @@ class AutomaticDashboardAppInner extends Component {
                   <h2 className="text-wrap mr2">
                     {dashboard && <TransientTitle dashboard={dashboard} />}
                   </h2>
-                  {dashboard && dashboard.transient_filters && (
-                    <TransientFilters
-                      filter={dashboard.transient_filters}
-                      metadata={this.props.metadata}
-                    />
-                  )}
                 </div>
                 {savedDashboardId != null ? (
                   <Button className="ml-auto" disabled>{t`Saved`}</Button>
@@ -218,45 +208,6 @@ const TransientTitle = ({ dashboard }) =>
     <span>{dashboard.name}</span>
   ) : null;
 
-const TransientFilters = ({ filter, metadata }) => (
-  <div className="mt1 flex align-center text-medium text-bold">
-    {Q.getFilters({ filter }).map((f, index) => (
-      <TransientFilter key={index} filter={f} metadata={metadata} />
-    ))}
-  </div>
-);
-
-const TransientFilter = ({ filter, metadata }) => {
-  const dimension = getFilterDimension(filter, metadata);
-
-  return (
-    <div className="mr3">
-      <Icon
-        size={12}
-        name={getIconForFilter(filter, dimension)}
-        className="mr1"
-      />
-      <Filter filter={filter} metadata={metadata} />
-    </div>
-  );
-};
-
-const getIconForFilter = (filter, dimension) => {
-  const field = dimension?.field();
-
-  if (isSegment(filter)) {
-    return "star";
-  } else if (!field) {
-    return "label";
-  } else if (field.isDate()) {
-    return "calendar";
-  } else if (field.isLocation()) {
-    return "location";
-  } else {
-    return "label";
-  }
-};
-
 const RELATED_CONTENT = {
   compare: {
     title: t`Compare`,