Handle mutation of vizSetting column when syncing columns in a native question (#17279)
* Handle mutation of vizSetting column when syncing columns of a native question When calling Question's _syncNativeQuerySettings method we need to treat existing, mutated columns as invalid so that they are filtered out and a new column takes the existing column's place. The function we use to find valid columns, findColumnIndexForColumnSetting, will return true if it finds a matching field_ref OR a matching name, so we also need to check the addedColumns array we just created in order to remove any columns from vizSettings that also exist there, since we combine the two at the end of this method. * add unit tests for _syncNativeQuerySettings
Loading
Please register or sign in to comment