Skip to content
Snippets Groups Projects
Unverified Commit dee19dfb authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Handle mutation of vizSetting column when syncing columns in a native question (#17279)

* Handle mutation of vizSetting column when syncing columns of a native question

When calling Question's _syncNativeQuerySettings method we need to treat
existing, mutated columns as invalid so that they are filtered out and a
new column takes the existing column's place.

The function we use to find valid columns, findColumnIndexForColumnSetting,
will return true if it finds a matching field_ref OR a matching name, so we
also need to check the addedColumns array we just created in order to remove
any columns from vizSettings that also exist there, since we combine the two
at the end of this method.

* add unit tests for _syncNativeQuerySettings
parent c4d777ac
No related branches found
Tags v0.49.3 v1.49.3
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment