Skip to content
Snippets Groups Projects
Unverified Commit e055e0e1 authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Update normal-drivers-with-feature to use driver test db (#27112)

* Update normal-drivers-with-feature to use driver test db, not just the current test db

* Exclude failing mongo test

* Improve perf
parent aec048cd
No related branches found
No related tags found
No related merge requests found
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
[medley.core :as m] [medley.core :as m]
[metabase.db.connection :as mdb.connection] [metabase.db.connection :as mdb.connection]
[metabase.driver :as driver] [metabase.driver :as driver]
[metabase.driver.util :as driver.u]
[metabase.models.field :refer [Field]] [metabase.models.field :refer [Field]]
[metabase.models.table :refer [Table]] [metabase.models.table :refer [Table]]
[metabase.query-processor :as qp] [metabase.query-processor :as qp]
...@@ -45,7 +44,9 @@ ...@@ -45,7 +44,9 @@
(let [features (set (cons feature more-features))] (let [features (set (cons feature more-features))]
(set (for [driver (normal-drivers) (set (for [driver (normal-drivers)
:let [driver (tx/the-driver-with-test-extensions driver)] :let [driver (tx/the-driver-with-test-extensions driver)]
:when (set/subset? features (driver.u/features driver (data/db)))] :when (driver/with-driver driver
(let [db (data/db)]
(every? #(driver/database-supports? driver % db) features)))]
driver)))) driver))))
(alter-meta! #'normal-drivers-with-feature assoc :arglists (list (into ['&] (sort driver/driver-features)))) (alter-meta! #'normal-drivers-with-feature assoc :arglists (list (into ['&] (sort driver/driver-features))))
......
...@@ -470,7 +470,8 @@ ...@@ -470,7 +470,8 @@
(is (true? (close-hour? hour (.getHour now)))))))))) (is (true? (close-hour? hour (.getHour now))))))))))
(deftest datetime-math-with-extract-test (deftest datetime-math-with-extract-test
(mt/test-drivers (mt/normal-drivers-with-feature :date-arithmetics) ;; FIXME: mongo doesn't supports parsing strings as dates so we exclude it from this test temporarily (#27111)
(mt/test-drivers (disj (mt/normal-drivers-with-feature :date-arithmetics) :mongo)
(mt/dataset times-mixed (mt/dataset times-mixed
(doseq [{:keys [title expected query]} (doseq [{:keys [title expected query]}
[{:title "Nested date math then extract" [{:title "Nested date math then extract"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment