-
- Downloads
SQL in a sidebar - Milestone 2: Visual tweaks (#40694)
* Move all notebook containers styles to one place * Make NotebookStep wide again * Tweak sidebar width and breakpoints * Remove top margin from NotebookSteps * Stop line wrapping in an ace editor * Uniform width between step header and step body * Remove stray styles * Scroll content independently * Use named export * Use Mantine button for "Visualize" * Convert notebook step width to rem * Adjust the position of the step close button * Adjust notebook step max-width to 1200px * Remove the `cx` where not needed * Use HTML 5 `aside` element for the sidebar * Use Mantine responsive styles * Fix E2E test
Showing
- e2e/test/scenarios/question/notebook.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/question/notebook.cy.spec.js
- frontend/src/metabase/query_builder/components/notebook/Notebook.styled.tsx 0 additions, 13 deletions...ase/query_builder/components/notebook/Notebook.styled.tsx
- frontend/src/metabase/query_builder/components/notebook/Notebook.tsx 5 additions, 6 deletions...c/metabase/query_builder/components/notebook/Notebook.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookStep/NotebookStep.styled.tsx 2 additions, 5 deletions.../components/notebook/NotebookStep/NotebookStep.styled.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookSteps/NotebookSteps.styled.tsx 0 additions, 5 deletions...omponents/notebook/NotebookSteps/NotebookSteps.styled.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookSteps/NotebookSteps.tsx 3 additions, 9 deletions...ilder/components/notebook/NotebookSteps/NotebookSteps.tsx
- frontend/src/metabase/query_builder/components/notebook/NotebookSteps/index.ts 1 addition, 2 deletions.../query_builder/components/notebook/NotebookSteps/index.ts
- frontend/src/metabase/query_builder/components/view/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.module.css 0 additions, 11 deletions...eQueryPreviewSidebar/NativeQueryPreviewSidebar.module.css
- frontend/src/metabase/query_builder/components/view/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx 1 addition, 10 deletions...w/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx
- frontend/src/metabase/query_builder/components/view/View/NotebookContainer/NotebookContainer.module.css 35 additions, 0 deletions.../view/View/NotebookContainer/NotebookContainer.module.css
- frontend/src/metabase/query_builder/components/view/View/NotebookContainer/NotebookContainer.tsx 18 additions, 7 deletions...ponents/view/View/NotebookContainer/NotebookContainer.tsx
Loading
Please register or sign in to comment