Only return help text for supported features (#39766)

Avoid showing the help test dialog for unsupported features

frontend/src/metabase-lib/expressions/suggest.ts

@@ -82,7 +82,12 @@ export function suggest({
       if (name && database) {
         const helpText = getHelpText(name, database, reportTimezone);
         if (helpText) {
-          return { suggestions, helpText };
+          const clause = MBQL_CLAUSES[helpText?.name];
+          const isSupported =
+            !clause || database?.hasFeature(clause.requiresFeature);
+          if (isSupported) {
+            return { suggestions, helpText };
+          }
         }
       }
     }

frontend/src/metabase-lib/expressions/suggest.unit.spec.ts

 import _ from "underscore";
 
+import { createMockMetadata } from "__support__/metadata";
 import * as Lib from "metabase-lib";
 import {
   SAMPLE_DATABASE,
@@ -8,6 +9,7 @@ import {
 } from "metabase-lib/test-helpers";
 import type { DatasetQuery, Join } from "metabase-types/api";
 import {
+  createSampleDatabase,
   ORDERS,
   ORDERS_ID,
   REVIEWS,
@@ -278,6 +280,27 @@ describe("metabase/lib/expression/suggest", () => {
         });
       });
 
+      it("should not provide help text for an unsupported function (metabase#39766)", () => {
+        const metadata = createMockMetadata({
+          databases: [
+            createSampleDatabase({
+              features: ["foreign-keys"],
+            }),
+          ],
+        });
+
+        expect(
+          helpText({
+            source: "percentile",
+            query: createQuery(),
+            metadata,
+            startRule: "expression",
+            stageIndex: -1,
+            getColumnIcon: () => "icon",
+          }),
+        ).toBeUndefined();
+      });
+
       it("should provide help text after first argument if there's only one argument", () => {
         expect(
           helpText({