Fix lineage issue

frontend/src/metabase/query_builder/actions.js

@@ -1051,14 +1051,21 @@ export const persistDefaultVisualizationSettings = () => {
         const series = getTransformedSeries(getState())
 
         const updatedQuestion = getQuestionWithDefaultVisualizationSettings(question, series)
-        dispatch(updateQuestion(updatedQuestion))
+        if (updatedQuestion !== question) dispatch(updateQuestion(updatedQuestion))
     }
 }
 
 const getQuestionWithDefaultVisualizationSettings = (question, series) => {
     const oldVizSettings = question.visualizationSettings()
     const newVizSettings = { ...getPersistableDefaultSettings(series), ...oldVizSettings }
-    return question.setVisualizationSettings(newVizSettings)
+
+    // Don't update the question unnecessarily
+    // (even if fields values haven't changed, updating the settings will make the question appear dirty)
+    if (!_.isEqual(oldVizSettings, newVizSettings)) {
+        return question.setVisualizationSettings(newVizSettings)
+    } else {
+        return question
+    }
 }
 
 export const QUERY_ERRORED = "metabase/qb/QUERY_ERRORED";

frontend/src/metabase/query_builder/components/AlertModals.jsx

@@ -501,9 +501,10 @@ export class AlertEditChannels extends Component {
 class RawDataAlertTip extends Component {
     render() {
         const display = this.props.question.display()
+        const vizSettings = this.props.visualizationSettings
         const isLineAreaBar = display === "line" || display === "area" || display === "bar"
-        const isMultiSeries = this.props.visualizationSettings["graph.metrics"].length > 1
-        const showMultiSeriesWarning = isLineAreaBar && isMultiSeries
+        const isMultiSeries =
+            isLineAreaBar && vizSettings["graph.metrics"] && vizSettings["graph.metrics"].length > 1
 
         return (
             <div className="border-row-divider p3 flex align-center">
@@ -511,7 +512,7 @@ class RawDataAlertTip extends Component {
                     <Icon name="lightbulb" size="20" />
                 </div>
                 <div>
-                    { showMultiSeriesWarning
+                    { isMultiSeries
                         ? jt`${<strong>Heads up:</strong>} Goal-based alerts aren't yet supported for charts with more than one line, so this alert will be sent whenever the chart has ${<em>results</em>}.`
                         : jt`${<strong>Tip:</strong>} This kind of alert is most useful when your saved question doesn’t ${<em>usually</em>} return any results, but you want to know when it does.`
                     }