-
- Downloads
[MLv2] [FE] Migrate data reference (#37694)
* Migrate StructuredQuery.prototype.filter in ObjectDetailView * [MLv2] Add `legacy-column->metadata` for converting `DatasetColumn` The query and stage are unfortunately required to correctly handle aggregation references. Note that the JS version of this name is `legacy_column__GT_metadata`, with the double underscore. * Add TS wrapper * Use fromLegacyColumn * Make code more backwards-compatible * Make code more backwards-compatible * Remove type argument from startNewCard * Migrate startNewcard in actions/object-detail to MLv2 * Fix filter clause * Use numberFilterClause when dealing with numbers * Use numberFilterClause when dealing with numbers in ObjectDetailView * Always pass metadata to getQuestionUrl * Partially migrate getQuestion * Handle metricId & segmentId in getQuestion * Order functions * Return after handling the metric and use setDisplay after handling all the clauses * Update frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailView.tsx Co-authored-by:Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Do not pass tableId to Question.create * Rename aggregateCount to aggregateByCount * Do not pass tableId to Question.create * Simplify code * Get databaseId from Question instea of raw dataset query * Fix code order * Allow Field to be passed to fromLegacyColumn * Prettier * Handle fieldId in getQuestion * Drop getQuestionOld * Drop startNewCard * Move aggregateByCount to metabase-lib/aggregation * Migrate loadObjectDetailFKReferences to MLv2 * Reuse Lib.aggregateByCount * Reverse logic * Use proper Field type * Handle field not being present in metadata * Remove Q_DEPRECATED.createQuery * Remove unused argument * Make ObjectDetail.unit.spec.tsx tests pass * Fix setting display * Fix typo * Add missing typing * Fix withDefaultTemporalBucket usage * Update getQuestion tests * Add `null` to aggregation assertions - pending question: https://metaboat.slack.com/archives/C04CYTEL9N2/p1705408133622419 * Remove unnecessary props argument from getMetadata calls * Add missing metadata * Handle missing table * Format code * Make sure setDisplay is called even if table is not available * Use correct values in assertions * Skip tests failing because of BE issue --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Showing
- frontend/src/metabase-lib/aggregation.ts 17 additions, 0 deletionsfrontend/src/metabase-lib/aggregation.ts
- frontend/src/metabase-lib/binning.ts 3 additions, 3 deletionsfrontend/src/metabase-lib/binning.ts
- frontend/src/metabase-lib/buckets.ts 1 addition, 1 deletionfrontend/src/metabase-lib/buckets.ts
- frontend/src/metabase-lib/metadata.ts 2 additions, 6 deletionsfrontend/src/metabase-lib/metadata.ts
- frontend/src/metabase-lib/queries/utils/index.js 0 additions, 32 deletionsfrontend/src/metabase-lib/queries/utils/index.js
- frontend/src/metabase-lib/temporal_bucket.ts 1 addition, 1 deletionfrontend/src/metabase-lib/temporal_bucket.ts
- frontend/src/metabase/lib/card.js 0 additions, 9 deletionsfrontend/src/metabase/lib/card.js
- frontend/src/metabase/query_builder/actions/object-detail.js 42 additions, 34 deletionsfrontend/src/metabase/query_builder/actions/object-detail.js
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/SummarizeSidebar.tsx 3 additions, 11 deletions...nents/view/sidebars/SummarizeSidebar/SummarizeSidebar.tsx
- frontend/src/metabase/reference/databases/TableDetail.jsx 9 additions, 2 deletionsfrontend/src/metabase/reference/databases/TableDetail.jsx
- frontend/src/metabase/reference/databases/TableQuestions.jsx 9 additions, 3 deletionsfrontend/src/metabase/reference/databases/TableQuestions.jsx
- frontend/src/metabase/reference/metrics/MetricDetail.jsx 5 additions, 0 deletionsfrontend/src/metabase/reference/metrics/MetricDetail.jsx
- frontend/src/metabase/reference/metrics/MetricQuestions.jsx 9 additions, 3 deletionsfrontend/src/metabase/reference/metrics/MetricQuestions.jsx
- frontend/src/metabase/reference/segments/SegmentDetail.jsx 10 additions, 6 deletionsfrontend/src/metabase/reference/segments/SegmentDetail.jsx
- frontend/src/metabase/reference/segments/SegmentFieldDetail.jsx 9 additions, 6 deletions...nd/src/metabase/reference/segments/SegmentFieldDetail.jsx
- frontend/src/metabase/reference/segments/SegmentQuestions.jsx 8 additions, 3 deletions...tend/src/metabase/reference/segments/SegmentQuestions.jsx
- frontend/src/metabase/reference/utils.js 71 additions, 37 deletionsfrontend/src/metabase/reference/utils.js
- frontend/src/metabase/reference/utils.unit.spec.js 89 additions, 65 deletionsfrontend/src/metabase/reference/utils.unit.spec.js
- frontend/test/metabase/lib/query.unit.spec.js 0 additions, 44 deletionsfrontend/test/metabase/lib/query.unit.spec.js
Loading
Please register or sign in to comment