-
- Downloads
Adds missing schemas + data for metrics to snowplow stats ping (#48476) (#48760)
* adds data + schema for metrics stats ping
* remove comment
* annotate todos
* fill in the rest of the metrics values
- and add defaults
* fix some definitions + use a single timestamp
* shuffle stuff around to appease the namespace linter
- we aren't reaching into the api API, so the linter is more of a
formality here.
* update docstring
* fix jsonschema, maybe
* review responses
- revert changes to 1-0-0
- add metrics section to new file: 1-0-1
- bump ::instance_stats to "1-0-1"
- add tags into 1-0-1
- make the code return tags (empty for now until we know what to tag things.)
- also fix test that broke from shuffling settings around
* remove a footgun
* add tags to metrics,
add grouped_metrics to jsonschema 1-0-1
format 1-0-1
* indent
* cljfmt
* version should match filename
* update instance stats 1-0-1 schema
* require `tags` in grouped_metric + snowcat comment
* fix formatting noise
* update schema to make it valid
* remove grouped_metrics from instance_stats schema
* cljfmt appeasement
* unbin cache_num_queries_cached value
- alphabetize metrics generation
* we can now guarantee metric values will be ints
* jsonschema for instance_uuid, settings, and grouped_metrics
* add analytics_uuid and make it required
* lint + alphabetize instance stats json schema
* update setting key type
- add maxLength to some strings
* lint jsonschema
- Add description to setting.items.tags
- add maxLength, and {min,max}imum to setting.items.value
* Bump instance stats to 2-0-0
- remove analytics_uuid string length == 36 check
- adds assertion to ensure required fields are set (and it passes)
- adds info for embedding settings
* adds a grouped-metric to stats ping
- adds length info to the schema to pass jsonschema linting
* cljfmt
Co-authored-by:
bryan <bryan.maass@gmail.com>
Showing
- .clj-kondo/config.edn 1 addition, 0 deletions.clj-kondo/config.edn
- snowplow/iglu-client-embedded/schemas/com.metabase/instance_stats/jsonschema/2-0-0 211 additions, 0 deletions...dded/schemas/com.metabase/instance_stats/jsonschema/2-0-0
- src/metabase/analytics/snowplow.clj 8 additions, 2 deletionssrc/metabase/analytics/snowplow.clj
- src/metabase/analytics/stats.clj 157 additions, 25 deletionssrc/metabase/analytics/stats.clj
- src/metabase/api/embed/common.clj 5 additions, 23 deletionssrc/metabase/api/embed/common.clj
- src/metabase/eid_translation.clj 9 additions, 0 deletionssrc/metabase/eid_translation.clj
- test/metabase/api/embed/common_test.clj 15 additions, 7 deletionstest/metabase/api/embed/common_test.clj
Loading
Please register or sign in to comment