-
- Downloads
Add `prettify-native-form` driver multimethod and refactor `mdb.query/format-sql` (#34991)
* Add multimethod to pretty-format native form `driver/prettify-native-form` is added. It is added to `driver` namespace, even though at the time of writing there is no need to pretty format nosql, eg. mongo, but this way branchings, as present in `dataset/native`, or rather `mbql.query/format-sql` can be avoided. * Move and update `mdb.query/format-sql` * Add `prettify-native-form` sql implementation * Refactor endpoint `/dataset/native` * Update docstring in `prettify-native-form` `prettify-native-form`has now docstring explaining its relationship to `sql.u/format-sql`. * Update tests * Refactor references in sql-jdbc code * Implement `prettify-native-form`in drivers - sqlserver - oracle - bigquery-cloud-sdk * Update test format-sql references * Refactor modules use of format-sql * Correct whitespace * Correct whitespace for bigquery * Update test Make `nonsql-dialects-return-original-query-test` run only for mongo as it now requires initialized mongo driver - mongo paths on class path. * Update docstring (review suggestions) For `prettify-native-form`. * Update docstring (review suggestion) For `mdb.query/format-sql`. * Whitespace (review suggestions) * Update docs (review suggestions)
Showing
- docs/developers-guide/driver-changelog.md 3 additions, 0 deletionsdocs/developers-guide/driver-changelog.md
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj 5 additions, 0 deletions...uery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj
- modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj 4 additions, 5 deletions...loud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj
- modules/drivers/oracle/src/metabase/driver/oracle.clj 4 additions, 0 deletionsmodules/drivers/oracle/src/metabase/driver/oracle.clj
- modules/drivers/oracle/test/metabase/driver/oracle_test.clj 1 addition, 2 deletionsmodules/drivers/oracle/test/metabase/driver/oracle_test.clj
- modules/drivers/oracle/test/metabase/test/data/oracle.clj 2 additions, 2 deletionsmodules/drivers/oracle/test/metabase/test/data/oracle.clj
- modules/drivers/redshift/test/metabase/driver/redshift_test.clj 2 additions, 2 deletions...s/drivers/redshift/test/metabase/driver/redshift_test.clj
- modules/drivers/sparksql/test/metabase/driver/sparksql_test.clj 3 additions, 3 deletions...s/drivers/sparksql/test/metabase/driver/sparksql_test.clj
- modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj 4 additions, 0 deletionsmodules/drivers/sqlserver/src/metabase/driver/sqlserver.clj
- modules/drivers/vertica/test/metabase/driver/vertica_test.clj 1 addition, 2 deletions...les/drivers/vertica/test/metabase/driver/vertica_test.clj
- src/metabase/api/dataset.clj 6 additions, 8 deletionssrc/metabase/api/dataset.clj
- src/metabase/db/query.clj 5 additions, 37 deletionssrc/metabase/db/query.clj
- src/metabase/driver.clj 24 additions, 0 deletionssrc/metabase/driver.clj
- src/metabase/driver/sql.clj 5 additions, 0 deletionssrc/metabase/driver/sql.clj
- src/metabase/driver/sql/util.clj 38 additions, 0 deletionssrc/metabase/driver/sql/util.clj
- src/metabase/driver/sql_jdbc/execute.clj 2 additions, 3 deletionssrc/metabase/driver/sql_jdbc/execute.clj
- test/metabase/db/query_test.clj 0 additions, 53 deletionstest/metabase/db/query_test.clj
- test/metabase/driver/mysql_test.clj 2 additions, 3 deletionstest/metabase/driver/mysql_test.clj
- test/metabase/driver/postgres_test.clj 3 additions, 4 deletionstest/metabase/driver/postgres_test.clj
- test/metabase/driver/sql/parameters/substitute_test.clj 1 addition, 2 deletionstest/metabase/driver/sql/parameters/substitute_test.clj
Loading
Please register or sign in to comment