Skip to content
Snippets Groups Projects
Unverified Commit e6fd2ed2 authored by lbrdnk's avatar lbrdnk Committed by GitHub
Browse files

Add `prettify-native-form` driver multimethod and refactor `mdb.query/format-sql` (#34991)

* Add multimethod to pretty-format native form

`driver/prettify-native-form` is added. It is added to `driver`
namespace, even though at the time of writing there is no need
to pretty format nosql, eg. mongo, but this way branchings,
as present in `dataset/native`, or rather `mbql.query/format-sql`
can be avoided.

* Move and update `mdb.query/format-sql`

* Add `prettify-native-form` sql implementation

* Refactor endpoint `/dataset/native`

* Update docstring in `prettify-native-form`

`prettify-native-form`has now docstring explaining its relationship
to `sql.u/format-sql`.

* Update tests

* Refactor references in sql-jdbc code

* Implement `prettify-native-form`in drivers

- sqlserver
- oracle
- bigquery-cloud-sdk

* Update test format-sql references

* Refactor modules use of format-sql

* Correct whitespace

* Correct whitespace for bigquery

* Update test

Make `nonsql-dialects-return-original-query-test` run only for mongo
as it now requires initialized mongo driver - mongo paths on class path.

* Update docstring (review suggestions)

For `prettify-native-form`.

* Update docstring (review suggestion)

For `mdb.query/format-sql`.

* Whitespace (review suggestions)

* Update docs (review suggestions)
parent ad9742cd
Branches
Tags
No related merge requests found
Showing
with 115 additions and 126 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment