Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
e855f7e5
Unverified
Commit
e855f7e5
authored
6 years ago
by
Kyle Doherty
Committed by
GitHub
6 years ago
Browse files
Options
Downloads
Patches
Plain Diff
use table instead of flex layout for revisions (#8092)
parent
c0d3239c
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/components/HistoryModal.jsx
+36
-38
36 additions, 38 deletions
frontend/src/metabase/components/HistoryModal.jsx
with
36 additions
and
38 deletions
frontend/src/metabase/components/HistoryModal.jsx
+
36
−
38
View file @
e855f7e5
...
...
@@ -74,55 +74,53 @@ export default class HistoryModal extends Component {
}
render
()
{
let
{
revisions
}
=
this
.
props
;
const
{
revisions
}
=
this
.
props
;
const
cellClassName
=
"
p1 border-bottom
"
;
return
(
<
ModalContent
title
=
{
t
`Revision history`
}
onClose
=
{
()
=>
this
.
props
.
onClose
()
}
>
<
LoadingAndErrorWrapper
className
=
"flex flex-full flex-basis-auto"
loading
=
{
!
revisions
}
error
=
{
this
.
state
.
error
}
>
<
LoadingAndErrorWrapper
loading
=
{
!
revisions
}
error
=
{
this
.
state
.
error
}
>
{
()
=>
(
<
div
className
=
"pb4 flex-full"
>
<
div
className
=
"border-bottom flex px4 py1 text-uppercase text-grey-3 text-bold h5"
>
<
span
className
=
"flex-half"
>
{
t
`When`
}
</
span
>
<
span
className
=
"flex-half"
>
{
t
`Who`
}
</
span
>
<
span
className
=
"flex-full"
>
{
t
`What`
}
</
span
>
</
div
>
<
div
className
=
"px2 scroll-y"
>
<
table
className
=
"full"
>
<
thead
>
<
tr
>
<
th
className
=
{
cellClassName
}
>
{
t
`When`
}
</
th
>
<
th
className
=
{
cellClassName
}
>
{
t
`Who`
}
</
th
>
<
th
className
=
{
cellClassName
}
>
{
t
`What`
}
</
th
>
<
th
className
=
{
cellClassName
}
/>
</
tr
>
</
thead
>
<
tbody
>
{
revisions
.
map
((
revision
,
index
)
=>
(
<
div
key
=
{
revision
.
id
}
className
=
"border-row-divider flex py1 px2"
>
<
span
className
=
"flex-half"
>
<
tr
key
=
{
revision
.
id
}
>
<
td
className
=
{
cellClassName
}
>
{
formatDate
(
revision
.
timestamp
)
}
</
span
>
<
span
className
=
"flex-half"
>
</
td
>
<
td
className
=
{
cellClassName
}
>
{
revision
.
user
.
common_name
}
</
span
>
<
span
className
=
"flex-full flex"
>
</
td
>
<
td
className
=
{
cellClassName
}
>
<
span
>
{
this
.
revisionDescription
(
revision
)
}
</
span
>
{
index
!==
0
?
(
<
div
className
=
"flex-align-right pl1"
>
<
ActionButton
actionFn
=
{
()
=>
this
.
revert
(
revision
)
}
className
=
"Button Button--small Button--danger text-uppercase"
normalText
=
{
t
`Revert`
}
active
Text
=
{
t
`Revert
ing…
`
}
failed
Text
=
{
t
`Revert
failed
`
}
success
Text
=
{
t
`Reverted`
}
/>
</
div
>
)
:
null
}
</
span
>
</
div
>
</
td
>
<
td
className
=
{
cellClassName
}
>
{
index
!==
0
&&
(
<
ActionButton
actionFn
=
{
()
=>
this
.
revert
(
revision
)
}
className
=
"Button Button--small Button--danger text-uppercase"
normal
Text
=
{
t
`Revert`
}
active
Text
=
{
t
`Revert
ing…
`
}
failed
Text
=
{
t
`Revert
fail
ed`
}
successText
=
{
t
`Reverted`
}
/
>
)
}
</
td
>
</
tr
>
))
}
</
div
>
</
div
>
</
tbody
>
</
table
>
)
}
</
LoadingAndErrorWrapper
>
</
ModalContent
>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment