Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
e88554fc
Commit
e88554fc
authored
8 years ago
by
Sameer Al-Sakran
Committed by
GitHub
8 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #3264 from metabase/fix_table_labels
fixes #3263
parents
6e8a08dd
ac26e199
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/visualizations/components/ChartSettings.jsx
+13
-2
13 additions, 2 deletions
.../src/metabase/visualizations/components/ChartSettings.jsx
with
13 additions
and
2 deletions
frontend/src/metabase/visualizations/components/ChartSettings.jsx
+
13
−
2
View file @
e88554fc
...
...
@@ -75,6 +75,18 @@ class ChartSettings extends Component {
return
assocIn
(
this
.
props
.
series
,
[
0
,
"
card
"
,
"
visualization_settings
"
],
this
.
state
.
settings
);
}
getChartTypeName
(){
switch
(
this
.
props
.
series
[
0
].
card
.
display
){
case
"
table
"
:
return
"
table
"
;
case
"
scalar
"
:
return
"
number
"
;
default
:
return
"
chart
"
;
}
}
render
()
{
const
{
onClose
}
=
this
.
props
;
...
...
@@ -88,12 +100,11 @@ class ChartSettings extends Component {
const
tabNames
=
Object
.
keys
(
tabs
);
const
currentTab
=
this
.
state
.
currentTab
||
tabNames
[
0
];
const
widgets
=
tabs
[
currentTab
];
const
isDirty
=
!
_
.
isEqual
(
this
.
props
.
series
[
0
].
card
.
visualization_settings
,
this
.
state
.
settings
);
return
(
<
div
className
=
"flex flex-column spread p4"
>
<
h2
className
=
"my2"
>
Customize this
chart
</
h2
>
<
h2
className
=
"my2"
>
Customize this
{
this
.
getChartTypeName
()
}
</
h2
>
{
tabNames
.
length
>
1
&&
<
ChartSettingsTabs
tabs
=
{
tabNames
}
selectTab
=
{
this
.
selectTab
}
activeTab
=
{
currentTab
}
/>
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment