Added trigger id for popovers with triggers

frontend/src/metabase/components/Triggerable.jsx

@@ -90,7 +90,7 @@ export default ComposedComponent => class extends Component {
     }
 
     render() {
-        const { triggerClasses, triggerClassesOpen } = this.props;
+        const { triggerId, triggerClasses, triggerClassesOpen } = this.props;
         const { isOpen } = this.state;
 
         let { triggerElement } = this.props;
@@ -106,7 +106,7 @@ export default ComposedComponent => class extends Component {
         }
 
         return (
-            <a ref="trigger" onClick={() => this.toggle()} className={cx("no-decoration", triggerClasses, isOpen ? triggerClassesOpen : null)}>
+            <a id={triggerId} ref="trigger" onClick={() => this.toggle()} className={cx("no-decoration", triggerClasses, isOpen ? triggerClassesOpen : null)}>
                 {triggerElement}
                 <ComposedComponent
                     {...this.props}

frontend/src/metabase/query_builder/VisualizationSettings.jsx

@@ -48,6 +48,7 @@ export default class VisualizationSettings extends React.Component {
                     id="VisualizationPopover"
                     ref="displayPopover"
                     className="ChartType-popover"
+                    triggerId="VisualizationTrigger"
                     triggerElement={triggerElement}
                     triggerClasses="flex align-center"
                 >

frontend/test/e2e/setup/signup.spec.js

@@ -126,6 +126,7 @@ describe("setup/signup", () => {
 
             // run query
             await waitForElement(driver, "img[src='/app/img/qb_tutorial/rocket.png']");
+            await driver.sleep(2000);
             await waitForAndClickElement(driver, ".Button.RunButton");
 
             await driver.sleep(20000);
@@ -134,7 +135,8 @@ describe("setup/signup", () => {
             console.log(logs);
 
             await waitForElement(driver, "img[src='/app/img/qb_tutorial/chart.png']", 60000);
-            await waitForAndClickElement(driver, ".VisualizationSettings>div>a");
+            await waitForAndClickElement(driver, "#VisualizationTrigger");
+            //FIXME: click doens't consistently land without timeout here
             await driver.sleep(1000);
             await waitForAndClickElement(driver, "#VisualizationPopover li:nth-child(3)");