Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
e9185095
Unverified
Commit
e9185095
authored
9 months ago
by
Chris Truter
Committed by
GitHub
9 months ago
Browse files
Options
Downloads
Patches
Plain Diff
Add dialect based feature flags for macaw (#45234)
parent
7af7213e
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/native_query_analyzer/impl.cljc
+11
-1
11 additions, 1 deletion
src/metabase/native_query_analyzer/impl.cljc
with
11 additions
and
1 deletion
src/metabase/native_query_analyzer/impl.cljc
+
11
−
1
View file @
e9185095
(
ns
metabase.native-query-analyzer.impl
)
(
ns
metabase.native-query-analyzer.impl
(
:require
[
metabase.driver
:as
driver
]))
;; NOTE: In the future we should replace [[considered-drivers]] and [[macaw-options]] with (a) driver method(s),
;; but given that the interface with Macaw is still in a state of flux, and how simple the current configuration is,
...
...
@@ -41,6 +43,14 @@
;; For both MySQL and SQL Server, whether identifiers are case-sensitive depends on database configuration only,
;; and quoting has no effect on this, so we disable this option for consistency with `:case-insensitive`.
:quotes-preserve-case?
(
not
(
contains?
#
{
:mysql
:sqlserver
}
driver
))
:features
{
:postgres-syntax
(
isa?
driver/hierarchy
driver
:postgres
)
:square-bracket-quotes
(
=
:sqlserver
driver
)
:unsupported-statements
true
:backslash-escape-char
true
;; This will slow things down, but until we measure the difference, opt for correctness.
:complex-parsing
true
}
;; 10 seconds
:timout
10000
;; There is no plan to be exhaustive yet.
;; Note that while an allowed list would be more conservative, at the time of writing only 2 of the bundled
;; drivers use FINAL as a reserved word, and mentioning them all would be prohibitive.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment