Skip to content
Snippets Groups Projects
Unverified Commit e925e2cd authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Uncomment audit-v2-views-test except the part that flakes (#37883)

parent 3982a6d1
Branches
Tags
No related merge requests found
......@@ -540,7 +540,6 @@
(testing "should drop the existing color column"
(is (not (contains? (t2/select-one :model/Collection :id collection-id) :color))))))))
#_ ;; TODO: this test is flaky so it's commented out for now
(deftest audit-v2-views-test
(testing "Migrations v48.00-029 - end"
;; Use an open-ended migration range so that we can detect if any migrations added after these views broke the view
......@@ -562,6 +561,7 @@
(doseq [view-name new-view-names]
(testing (str "View " view-name " should be created")
(is (= [] (t2/query (str "SELECT 1 FROM " view-name))))))
#_#_ ;; TODO: this is commented out temporarily because it flakes for MySQL (metabase#37434)
(migrate! :down 47)
(testing "Views should be removed when downgrading"
(doseq [view-name new-view-names]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment