Drop parameter_card.entity_id (#35134)

enterprise/backend/test/metabase_enterprise/serialization/v2/entity_ids_test.clj

 (ns metabase-enterprise.serialization.v2.entity-ids-test
   (:require
+   [clojure.set :as set]
    [clojure.string :as str]
    [clojure.test :refer :all]
    [metabase-enterprise.serialization.v2.entity-ids :as v2.entity-ids]
+   [metabase.config :as config]
    [metabase.models :refer [Collection Dashboard]]
    [metabase.test :as mt]
    [toucan2.core :as t2])
@@ -66,3 +68,52 @@
           (is (= true
                  (v2.entity-ids/drop-entity-ids!)))
           (is (nil? (t2/select-fn-set :entity-id Dashboard))))))))
+
+(deftest entity-models-test
+  (testing "Sanity check: list of models that does not need an entity_id column,
+           if this test fails, check if it really needs it.
+           If yes, makes surethe exported data includes `:entity_id` column
+           or the model implements [[serdes/hash-fields]] (#35097)"
+    (is (= (cond-> #{:model/MetricImportantField
+                     :model/ModerationReview
+                     :model/CollectionBookmark
+                     :model/Secret
+                     :model/GroupTableAccessPolicy
+                     :model/FieldValues
+                     :model/ModelIndex
+                     :model/DashboardCardSeries
+                     :model/ParameterCard
+                     :model/QueryAction
+                     :model/ImplicitAction
+                     :model/User
+                     :model/Revision
+                     :model/PermissionsRevision
+                     :model/CardBookmark
+                     :model/CollectionPermissionGraphRevision
+                     :model/BookmarkOrdering
+                     :model/ModelIndexValue
+                     :model/PermissionsGroupMembership
+                     :model/ViewLog
+                     :model/Field
+                     :model/QueryCache
+                     :model/ApplicationPermissionsRevision
+                     :model/LoginHistory
+                     :model/Database
+                     :model/Session
+                     :model/Permissions
+                     :model/TaskHistory
+                     :model/Setting
+                     :model/Activity
+                     :model/PulseChannelRecipient
+                     :model/TablePrivileges
+                     :model/TimelineEvent
+                     :model/PersistedInfo
+                     :model/HTTPAction
+                     :model/QueryExecution
+                     :model/DashboardBookmark
+                     :model/Table
+                     :model/Query
+                     :model/PermissionsGroup}
+             config/ee-available?
+             (conj :model/ConnectionImpersonation))
+           (set/difference (set (v2.entity-ids/toucan-models)) (#'v2.entity-ids/entity-id-models))))))

resources/migrations/000_migrations.yaml

@@ -15526,6 +15526,26 @@ databaseChangeLog:
             where: semantic_type = 'type/Number'
       rollback:
+  - changeSet:
+      id: v48.00-027
+      author: qnkhuat
+      comment: 'Drop parameter_card.entity_id'
+      changes:
+        - dropColumn:
+            tableName: parameter_card
+            columnName: entity_id
+      rollback:
+        - addColumn:
+            columns:
+            - column:
+                remarks: Random NanoID tag for unique identity.
+                name: entity_id
+                type: char(21)
+                constraints:
+                  nullable: true
+                  unique: true
+            tableName: parameter_card
+
   # >>>>>>>>>> DO NOT ADD NEW MIGRATIONS BELOW THIS LINE! ADD THEM ABOVE <<<<<<<<<<
 ########################################################################################################################

src/metabase/models/parameter_card.clj

@@ -18,8 +18,7 @@
 
 (doto :model/ParameterCard
   (derive :metabase/model)
-  (derive :hook/timestamped?)
-  (derive :hook/entity-id))
+  (derive :hook/timestamped?))
 
 (t2/deftransforms :model/ParameterCard
  {:parameterized_object_type mi/transform-keyword})