Move tests to own ns, user proper scafolding

test/metabase/driver/sql/query_processor_test.clj

 (ns metabase.driver.sql.query-processor-test
   (:require [expectations :refer [expect]]
-            [metabase.driver.sql.query-processor :as sql.qp]
-            [metabase.models.segment :refer [Segment]]
-            [metabase.query-processor :as qp]
-            [metabase.test.data :as data]
-            [toucan.util.test :as tt]))
+            [metabase.driver.sql.query-processor :as sql.qp]))
 
 ;; make sure our logic for deciding which order to process keys in the query works as expected
 (expect
@@ -15,34 +11,3 @@
                                               :aggregation  3
                                               :fields       4
                                               :breakout     2}))
-
-
-(defn- test-query
-  [query]
-  (:data (qp/process-query {:database (data/id)
-                            :type     :query
-                            :query    query})))
-
-(expect
-  0.94
-  (-> (test-query {:source-table (data/id :venues)
-                   :aggregation  [[:share [:< [:field-id (data/id :venues :price)] 4]]]})
-      :rows
-      ffirst
-      double))
-(expect
-  nil
-  (-> (test-query {:source-table (data/id :venues)
-                   :aggregation  [[:share [:< [:field-id (data/id :venues :price)] 4]]]
-                   :filter       [:> [:field-id (data/id :venues :price)] Long/MAX_VALUE]})
-      :rows
-      ffirst))
-(tt/expect-with-temp [Segment [{segment-id :id} {:table_id   (data/id :venues)
-                                                 :definition {:source-table (data/id :venues)
-                                                              :filter       [:< [:field-id (data/id :venues :price)] 4]}}]]
-   0.94
-   (-> (test-query {:source-table (data/id :venues)
-                    :aggregation  [[:share [:segment segment-id]]] })
-       :rows
-       ffirst
-       double))

test/metabase/query_processor_test/share_test.clj

+(ns metabase.query-processor-test.share-test
+  (:require [metabase.models.segment :refer [Segment]]
+            [metabase.query-processor :as qp]
+            [metabase.query-processor-test :refer :all]
+            [metabase.test.data :as data]
+            [metabase.test.data.datasets :as datasets]
+            [toucan.util.test :as tt]))
+
+(datasets/expect-with-drivers (non-timeseries-drivers-with-feature :basic-aggregations)
+  0.94
+  (->> {:aggregation [[:share [:< [:field-id (data/id :venues :price)] 4]]]}
+       (data/run-mbql-query venues)
+       rows
+       ffirst
+       double))
+
+(datasets/expect-with-drivers (non-timeseries-drivers-with-feature :basic-aggregations)
+  1.47
+  (->> {:aggregation [[:+ [:/ [:share [:< [:field-id (data/id :venues :price)] 4]] 2] 1]]}
+       (data/run-mbql-query venues)
+       rows
+       ffirst
+       double))
+
+(datasets/expect-with-drivers (non-timeseries-drivers-with-feature :basic-aggregations)
+  nil
+  (->> {:aggregation [[:share [:< [:field-id (data/id :venues :price)] 4]]]
+       :filter      [:> [:field-id (data/id :venues :price)] Long/MAX_VALUE]}
+       (data/run-mbql-query venues)
+       rows
+       ffirst))
+
+(datasets/expect-with-drivers (non-timeseries-drivers-with-feature :basic-aggregations)
+  0.94
+  (tt/with-temp* [Segment [{segment-id :id} {:table_id   (data/id :venues)
+                                             :definition {:source-table (data/id :venues)
+                                                          :filter       [:< [:field-id (data/id :venues :price)] 4]}}]]
+    (->> {:aggregation [[:share [:segment segment-id]]]}
+         (data/run-mbql-query venues)
+         rows
+         ffirst
+         double)))