Skip to content
Snippets Groups Projects
Unverified Commit eb8555a6 authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

fix object detail view is not scrollable on mobile (#45312)

parent a81b51e2
Branches table-level-native-block
No related tags found
No related merge requests found
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
createQuestion,
modal,
popover,
restore,
type StructuredQuestionDetails,
......@@ -37,3 +38,26 @@ describe("issue 43075", () => {
});
});
});
describe("issue 41133", () => {
const questionDetails: StructuredQuestionDetails = {
query: {
"source-table": PRODUCTS_ID,
},
};
beforeEach(() => {
cy.viewport(600, 400);
restore();
cy.signInAsAdmin();
createQuestion(questionDetails, { visitQuestion: true });
});
it("object detail view should be scrollable on narrow screens (metabase#41133)", () => {
cy.findByTestId("detail-shortcut").eq(0).click();
modal().within(() => {
cy.findByText("Created At").scrollIntoView().should("be.visible");
cy.findByText("is connected to:").scrollIntoView().should("be.visible");
});
});
});
......@@ -30,7 +30,7 @@ export const RootModal = styled(Modal)`
height: calc(80vh - 4rem);
}
height: calc(100vh - 8rem);
max-height: calc(100vh - 8rem);
}
${ObjectDetailsTable} {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment