-
- Downloads
[Apps] Add scaffolded pages to existing apps (#25343)
* [Apps] Add scaffolded pages to existing apps
Reuse app scaffolding in order to add to existing apps. This will not
check that the tables you choose have not been previously added to the app.
Also update scaffolding:
- Add back to list button
- Update list question to order by newest row on top.
- Use linkType: "page" instead of linkType: "dashboard"
* Fix H2 test, no need to add app-id to name
* Remove unused require
* Addressing review comments - suggested test uncovered an ordering bug
* Put priority back to ascending
* Implement navigation between data app pages (#25366)
* Add `DataAppPagePicker`
* Rename `QuestionDashboardPicker`
* Add page to `EntityCustomDestinationClickBehavior`
* Fix comment
* Use ellipsis character
* Fix custom destination type
* Add "page" custom destination to pickers
* Pass router props to dashboard click actions
* Remove not used function arguments
* Implement "page" custom destination click behavior
* Fix "page" click behavior isn't treated as valid
* Reorganize `LinkedEntityPicker`
* Fix drills from the homepage
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
Showing
- frontend/src/metabase-types/api/click-behavior.ts 6 additions, 2 deletionsfrontend/src/metabase-types/api/click-behavior.ts
- frontend/src/metabase/containers/DataAppPagePicker.jsx 20 additions, 0 deletionsfrontend/src/metabase/containers/DataAppPagePicker.jsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx 3 additions, 2 deletions...mponents/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker.tsx 39 additions, 20 deletions...s/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker.tsx
- frontend/src/metabase/lib/click-behavior.js 6 additions, 2 deletionsfrontend/src/metabase/lib/click-behavior.js
- frontend/src/metabase/modes/components/drill/DashboardClickDrill.jsx 27 additions, 0 deletions...c/metabase/modes/components/drill/DashboardClickDrill.jsx
- frontend/src/metabase/query_builder/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx 1 addition, 1 deletion...SelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx
- frontend/src/metabase/visualizations/hoc/WithVizSettingsData.js 66 additions, 59 deletions...nd/src/metabase/visualizations/hoc/WithVizSettingsData.js
- src/metabase/api/app.clj 97 additions, 52 deletionssrc/metabase/api/app.clj
- test/metabase/api/app_test.clj 41 additions, 2 deletionstest/metabase/api/app_test.clj
Loading
Please register or sign in to comment