Use arrow functions in e2e & unit tests definitions (#39512)

* Use arrow functions in e2e tests

* Use arrow functions in unit tests

e2e/test/scenarios/collections/reproductions/30235-turn-official-after-move.cy.spec.js

@@ -8,7 +8,7 @@ import {
   setTokenFeatures,
 } from "e2e/support/helpers";
 
-describeEE("issue 30235", function () {
+describeEE("issue 30235", () => {
   beforeEach(() => {
     restore();
     cy.signInAsAdmin();

e2e/test/scenarios/filters/reproductions/31340-long-column-name-search-results.cy.spec.js

@@ -7,7 +7,7 @@ const { PEOPLE_ID } = SAMPLE_DATABASE;
 const LONG_COLUMN_NAME =
   "Some very very very very long column name that should have a line break";
 
-describe("issue 31340", function () {
+describe("issue 31340", () => {
   beforeEach(() => {
     restore();
     cy.signInAsAdmin();

e2e/test/scenarios/visualizations-tabular/drillthroughs/table_drills.cy.spec.js

@@ -3,7 +3,7 @@ import { openReviewsTable, popover, restore } from "e2e/support/helpers";
 
 const { REVIEWS, REVIEWS_ID } = SAMPLE_DATABASE;
 
-describe("scenarios > visualizations > drillthroughs > table_drills", function () {
+describe("scenarios > visualizations > drillthroughs > table_drills", () => {
   beforeEach(() => {
     restore();
     cy.signInAsAdmin();

e2e/test/scenarios/visualizations-tabular/reproductions/37726-pivot-table-add-column.cy.spec.js

@@ -47,7 +47,7 @@ const PIVOT_QUESTION = {
   },
 };
 
-describe("issue 37726", function () {
+describe("issue 37726", () => {
   beforeEach(() => {
     restore();
     cy.signInAsNormalUser();

frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.unit.spec.tsx

@@ -23,7 +23,7 @@ async function setup({ hasAdvancedPermissions = false } = {}) {
   await waitForLoaderToBeRemoved();
 }
 
-describe("DataPermissionsHelp", function () {
+describe("DataPermissionsHelp", () => {
   it("shows link to the plans page on non-enterprise instances", () => {
     setup({ hasAdvancedPermissions: false });
 

frontend/src/metabase/admin/permissions/test/DatabasesPermissionsPage/DatabasesPermissionsPage.unit.spec.tsx

@@ -71,7 +71,7 @@ const editDatabasePermission = async () => {
   await delay(0);
 };
 
-describe("DatabasesPermissionsPage", function () {
+describe("DatabasesPermissionsPage", () => {
   afterEach(() => {
     jest.restoreAllMocks();
   });

frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx

@@ -72,7 +72,7 @@ const editDatabasePermission = async () => {
   await delay(0);
 };
 
-describe("GroupsPermissionsPage", function () {
+describe("GroupsPermissionsPage", () => {
   afterEach(() => {
     jest.restoreAllMocks();
   });

frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.unit.spec.tsx

@@ -114,7 +114,7 @@ async function setup({ dashboard }: Options = {}) {
   };
 }
 
-describe("DashboardApp", function () {
+describe("DashboardApp", () => {
   afterEach(() => {
     jest.clearAllMocks();
   });