Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

edb896f9

Unverified Commit edb896f9 authored 3 years ago by Noah Moss Committed by GitHub 3 years ago

Downloads
- Patches
- Plain Diff

Fix broken LDAP group lookups for Active Directory (#16331)

* adapt ldap test helpers to be able to test AD memberOf attribute

* fix ldap search to handle memberOf attributes with a single group

* use one-or-many instead of if statement

* fix tests

parent ae6e9d9f

Branches

Tags

No related merge requests found

Changes 4

Hide whitespace changes

Inline Side-by-side

Showing

src/metabase/integrations/ldap/default_implementation.clj 1 addition, 1 deletion

src/metabase/integrations/ldap/default_implementation.clj
test/metabase/integrations/ldap_test.clj 20 additions, 1 deletion

test/metabase/integrations/ldap_test.clj
test/metabase/test/integrations/ldap.clj 26 additions, 10 deletions

test/metabase/test/integrations/ldap.clj
test_resources/active_directory.ldif 56 additions, 0 deletions

test_resources/active_directory.ldif

with 103 additions and 12 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment