Prevent release artifacts colliding with test artifacts (#36663)

.github/workflows/build-for-release.yml

@@ -187,7 +187,7 @@ jobs:
     - name: Upload JARs as artifact
       uses: actions/upload-artifact@v3
       with:
-        name: metabase-${{ matrix.edition }}-${{ inputs.commit }}-uberjar
+        name: metabase-release-${{ matrix.edition }}-${{ inputs.commit }}-uberjar
         path: |
           ./metabase.jar
           ./COMMIT-ID

.github/workflows/pre-release.yml

@@ -35,7 +35,7 @@ jobs:
             const artifacts = await github.rest.actions.listArtifactsForRepo({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              name: `metabase-${{ matrix.edition }}-${{ inputs.commit }}-uberjar`,
+              name: `metabase-release-${{ matrix.edition }}-${{ inputs.commit }}-uberjar`,
               per_page: 1,
             });
 

.github/workflows/release.yml

@@ -36,7 +36,7 @@ jobs:
       uses: actions/github-script@v6
       id: canonical_version
       with:
-        script: |
+        script: | # js
           const { isValidVersionString, getCanonicalVersion, hasBeenReleased } = require('${{ github.workspace }}/release/dist/index.cjs');
 
           const version = '${{ inputs.version }}';
@@ -83,13 +83,13 @@ jobs:
       uses: actions/github-script@v6
       with:
         result-encoding: string
-        script: |
+        script: | # js
           const fs = require('fs');
 
           const artifacts = await github.rest.actions.listArtifactsForRepo({
             owner: context.repo.owner,
             repo: context.repo.repo,
-            name: `metabase-${{ matrix.edition }}-${{ inputs.commit }}-uberjar`,
+            name: `metabase-release-${{ matrix.edition }}-${{ inputs.commit }}-uberjar`,
             per_page: 1,
           });