Skip to content
Snippets Groups Projects
Unverified Commit edc969ce authored by Ngoc Khuat's avatar Ngoc Khuat Committed by GitHub
Browse files

Move logic to infer revision.description to BE (#30502)


* Dashboard Tab entity (#29802)

* add dashboard tab entity

* Dashboard tabs CRUD (#29861)

* Dashboard tabs frontend (#30189)

* rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`

commit-id:7cdfd86a

* add tabs to dash

commit-id:d3c2fa74

* improve code structure and other fixes

* rename `dashboardtab_id` to `dashboard_tab_id`

* remove explicit `position` logic

* improve code quality

* add renaming functionality

* add two new tabs when creating first tab

* hide tabs if there is only one

* add unit test for `DashboardTabs` component

* refactor

* fix type errors

* add `tabId` to text cards

* add `tabId` to link cards

* add `tabId` to action button

* use disabled state when only one tab remains

* refetch cards with filter value when changing tabs

* add e2e test

* fix broken e2e tests

* add horizontal scrolling

* fix unit test

* fix create tab button being on right

* fix performance issue when switching tabs

* add `ttag` to `tabs.ts`

* use `aria-label` in e2e test helper

* fix type error after rebasing

* making ordered_tabs optional for tests purposes

* fix failing unit tests

* fix failing e2e tests

* fix flaky revision history e2e test

* fix type error after merging feature branch with master and rebasing

* fix revisions unit test

* fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking

---------

Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>

* migrating revision logic to BE

* handle description for multiple cards add/remove

* test fixes

* adds tests

* make sures events are started so tests work

* remove additional `:maybe` that was added while rebasing

* add title and has_multile_changes to revision

* fixes potential test flake

* more tests

* remove debug code

* handles collection change description in card and dashboard

* fixes fail to build

* use backend for revision history (#30772)

* use BE response for revision history

* update `service.unit.spec.js`

* sort revision and moderation events for question timeline

* test fixes

* create revision directly instead of via API to avoid flake

* reverted to an earlier revision => reverted to an earlier version

* translate the model name too

* Rename functions:
- diff-strs -> diff-strings
- diff-strings -> diff-strings*
- diff-strings* -> diff-string

* move the diff to diff-strings*

* use case instead of map for model-str->i18n-str

* remove title from API response

* do not translate test model

* rename var `title_text` to `titleText`

* address comments

* stringify the display name

* fix revert button not working

* add loading wrapper to fix unit test

* fix tests

* fix type error

* fix QuestionActivityTimeline test

* add a dot for edited this

---------

Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
parent 9614786f
No related branches found
No related tags found
No related merge requests found
Showing
with 267 additions and 37 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment