-
- Downloads
Move logic to infer revision.description to BE (#30502)
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:Ngoc Khuat <qn.khuat@gmail.com> * migrating revision logic to BE * handle description for multiple cards add/remove * test fixes * adds tests * make sures events are started so tests work * remove additional `:maybe` that was added while rebasing * add title and has_multile_changes to revision * fixes potential test flake * more tests * remove debug code * handles collection change description in card and dashboard * fixes fail to build * use backend for revision history (#30772) * use BE response for revision history * update `service.unit.spec.js` * sort revision and moderation events for question timeline * test fixes * create revision directly instead of via API to avoid flake * reverted to an earlier revision => reverted to an earlier version * translate the model name too * Rename functions: - diff-strs -> diff-strings - diff-strings -> diff-strings* - diff-strings* -> diff-string * move the diff to diff-strings* * use case instead of map for model-str->i18n-str * remove title from API response * do not translate test model * rename var `title_text` to `titleText` * address comments * stringify the display name * fix revert button not working * add loading wrapper to fix unit test * fix tests * fix type error * fix QuestionActivityTimeline test * add a dot for edited this --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
Showing
- e2e/test/scenarios/models/models-revision-history.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/models/models-revision-history.cy.spec.js
- e2e/test/scenarios/native-filters/reproductions/12581.cy.spec.js 2 additions, 2 deletions...t/scenarios/native-filters/reproductions/12581.cy.spec.js
- e2e/test/scenarios/question/saved.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/question/saved.cy.spec.js
- enterprise/frontend/src/metabase-enterprise/moderation/service.js 2 additions, 2 deletions...se/frontend/src/metabase-enterprise/moderation/service.js
- enterprise/frontend/src/metabase-enterprise/moderation/service.unit.spec.js 2 additions, 2 deletions...d/src/metabase-enterprise/moderation/service.unit.spec.js
- frontend/src/metabase-types/api/mocks/revision.ts 21 additions, 0 deletionsfrontend/src/metabase-types/api/mocks/revision.ts
- frontend/src/metabase-types/api/mocks/user.ts 12 additions, 1 deletionfrontend/src/metabase-types/api/mocks/user.ts
- frontend/src/metabase-types/api/revision.ts 16 additions, 7 deletionsfrontend/src/metabase-types/api/revision.ts
- frontend/src/metabase-types/api/user.ts 8 additions, 0 deletionsfrontend/src/metabase-types/api/user.ts
- frontend/src/metabase/common/components/Timeline/Timeline.styled.tsx 10 additions, 19 deletions...c/metabase/common/components/Timeline/Timeline.styled.tsx
- frontend/src/metabase/common/components/Timeline/Timeline.tsx 84 additions, 0 deletions...tend/src/metabase/common/components/Timeline/Timeline.tsx
- frontend/src/metabase/common/components/Timeline/index.ts 1 addition, 0 deletionsfrontend/src/metabase/common/components/Timeline/index.ts
- frontend/src/metabase/common/components/Timeline/utils.ts 31 additions, 0 deletionsfrontend/src/metabase/common/components/Timeline/utils.ts
- frontend/src/metabase/common/hooks/use-database-list-query/use-database-list-query.ts 1 addition, 0 deletions.../hooks/use-database-list-query/use-database-list-query.ts
- frontend/src/metabase/common/hooks/use-entity-list-query/use-entity-list-query.ts 5 additions, 2 deletions...mmon/hooks/use-entity-list-query/use-entity-list-query.ts
- frontend/src/metabase/common/hooks/use-metric-list-query/use-metric-list-query.ts 1 addition, 0 deletions...mmon/hooks/use-metric-list-query/use-metric-list-query.ts
- frontend/src/metabase/common/hooks/use-question-list-query/use-question-list-query.ts 1 addition, 0 deletions.../hooks/use-question-list-query/use-question-list-query.ts
- frontend/src/metabase/common/hooks/use-revision-list-query/index.ts 1 addition, 0 deletions...rc/metabase/common/hooks/use-revision-list-query/index.ts
- frontend/src/metabase/common/hooks/use-revision-list-query/use-revision-list-query.ts 19 additions, 0 deletions.../hooks/use-revision-list-query/use-revision-list-query.ts
- frontend/src/metabase/common/hooks/use-revision-list-query/use-revision-list-query.unit.spec.tsx 48 additions, 0 deletions...revision-list-query/use-revision-list-query.unit.spec.tsx
Loading
Please register or sign in to comment