Fix LDAP auth if attributes are arrays (#10913)

src/metabase/models/user.clj

@@ -15,7 +15,7 @@
              [permissions-group-membership :as perm-membership :refer [PermissionsGroupMembership]]]
             [metabase.util
              [date :as du]
-             [i18n :refer [deferred-tru trs]]
+             [i18n :refer [trs]]
              [schema :as su]]
             [schema.core :as s]
             [toucan
@@ -176,9 +176,8 @@
     (email/send-new-user-email! new-user invitor join-url)))
 
 (def LoginAttributes
-  "Login attributes, currently not collected for LDAP or Google Auth. Will ultimately be stored as JSON"
-  (su/with-api-error-message {su/KeywordOrString (s/cond-pre s/Str s/Num)}
-    (deferred-tru "value must be a map with each value either a string or number.")))
+  "Login attributes, currently not collected for LDAP or Google Auth. Will ultimately be stored as JSON."
+  {su/KeywordOrString s/Any})
 
 (def NewUser
   "Required/optionals parameters needed to create a new user (for any backend)"

test/metabase/models/user_test.clj

@@ -182,6 +182,18 @@
   (tt/with-temp User [user {:is_superuser true}]
     (db/exists? PermissionsGroupMembership :user_id (u/get-id user), :group_id (u/get-id (group/admin)))))
 
+;; You should be able to create a new LDAP user if some `login_attributes` are vectors (#10291)
+(expect
+  {"local_birds" ["Steller's Jay" "Mountain Chickadee"]}
+  (try
+    (user/create-new-ldap-auth-user! {:email            "ldaptest@metabase.com"
+                                      :first_name       "Test"
+                                      :last_name        "SomeLdapStuff"
+                                      :login_attributes {:local_birds ["Steller's Jay" "Mountain Chickadee"]}})
+    (db/select-one-field :login_attributes User :email "ldaptest@metabase.com")
+    (finally
+      (db/delete! User :email "ldaptest@metabase.com"))))
+
 
 ;;; +----------------------------------------------------------------------------------------------------------------+
 ;;; |                                            New Group IDs Functions                                             |