Exclude summarize-column-by-time drill-thru for aggregate columns (#34456)

src/metabase/lib/drill_thru/summarize_column_by_time.cljc

@@ -22,7 +22,8 @@
              column
              (nil? value)
              (not (lib.types.isa/structured? column))
-             (lib.types.isa/summable? column))
+             (lib.types.isa/summable? column)
+             (not= (:lib/source column) :source/aggregations))
     ;; There must be a date dimension available.
     (when-let [breakout-column (m/find-first lib.types.isa/temporal?
                                              (lib.breakout/breakoutable-columns query stage-number))]

test/metabase/lib/drill_thru/summarize_column_by_time_test.cljc

+(ns metabase.lib.drill-thru.summarize-column-by-time-test
+  (:require
+   [clojure.test :refer [deftest is testing]]
+   [medley.core :as m]
+   [metabase.lib.core :as lib]
+   [metabase.lib.drill-thru.summarize-column-by-time :as lib.drill-thru.summarize-column-by-time]
+   [metabase.lib.test-metadata :as meta]
+   #?@(:cljs ([metabase.test-runner.assert-exprs.approximately-equal]))))
+
+#?(:cljs (comment metabase.test-runner.assert-exprs.approximately-equal/keep-me))
+
+(deftest ^:parallel aggregate-column-test
+  (testing "Don't suggest summarize-column-by-time drill thrus for aggregate columns like `count(*)`"
+    (let [query     (-> (lib/query meta/metadata-provider (meta/table-metadata :orders))
+                        (lib/aggregate (lib/count))
+                        (lib/breakout (meta/field-metadata :orders :product-id)))
+          count-col (m/find-first (fn [col]
+                                    (= (:display-name col) "Count"))
+                                  (lib/returned-columns query))
+          context   {:column count-col
+                     :value  nil}]
+      (is (some? count-col))
+      (is (nil? (lib.drill-thru.summarize-column-by-time/summarize-column-by-time-drill query -1 context))))))