Skip to content
Snippets Groups Projects
Unverified Commit f184a0db authored by Nemanja Glumac's avatar Nemanja Glumac Committed by GitHub
Browse files

Synchronize `ExternalLink` component with the `release-x.39.x` (#16145)

parent 5caf4de8
Branches
Tags
No related merge requests found
......@@ -43,7 +43,7 @@ export default class SettingsUpdatesForm extends Component {
{jt`You're running ${formatVersion(currentVersion)}`}
</span>
<ExternalLink
dataMetabaseEvent={
data-metabase-event={
"Updates Settings; Update link clicked; " + latestVersion
}
className="Button Button--white Button--medium borderless"
......
......@@ -7,14 +7,12 @@ const ExternalLink = ({
href,
target = getUrlTarget(href),
className,
dataMetabaseEvent,
children,
...props
}) => (
<a
href={href}
className={className || "link"}
data-metabase-event={dataMetabaseEvent}
target={target}
// prevent malicious pages from navigating us away
rel="noopener noreferrer"
......
......@@ -299,7 +299,7 @@ const TagEditorHelp = ({
<ExternalLink
href={MetabaseSettings.docsUrl("users-guide/13-sql-parameters")}
target="_blank"
dataMetabaseEvent="QueryBuilder;Template Tag Documentation Click"
data-metabase-event={"QueryBuilder;Template Tag Documentation Click"}
>{t`Read the full documentation`}</ExternalLink>
</p>
</div>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment