Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
f2680bb0
Commit
f2680bb0
authored
7 years ago
by
Atte Keinänen
Browse files
Options
Downloads
Patches
Plain Diff
Instrument remapping admin settings
parent
5d7c47f4
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/admin/datamodel/containers/FieldApp.jsx
+8
-1
8 additions, 1 deletion
...tend/src/metabase/admin/datamodel/containers/FieldApp.jsx
with
8 additions
and
1 deletion
frontend/src/metabase/admin/datamodel/containers/FieldApp.jsx
+
8
−
1
View file @
f2680bb0
...
...
@@ -16,6 +16,7 @@ import Select from 'metabase/components/Select'
import
SaveStatus
from
"
metabase/components/SaveStatus
"
;
import
Breadcrumbs
from
"
metabase/components/Breadcrumbs
"
;
import
ButtonWithStatus
from
"
metabase/components/ButtonWithStatus
"
;
import
MetabaseAnalytics
from
"
metabase/lib/analytics
"
;
import
{
getMetadata
}
from
"
metabase/selectors/metadata
"
;
import
*
as
metadataActions
from
"
metabase/redux/metadata
"
;
...
...
@@ -268,7 +269,7 @@ export class FieldHeader extends Component {
/>
</
div
>
)
}
}
}
// consider renaming this component to something more descriptive
...
...
@@ -313,6 +314,7 @@ export class ValueRemappings extends Component {
}
onSaveClick
=
()
=>
{
MetabaseAnalytics
.
trackEvent
(
"
Data Model
"
,
"
Update Custom Remappings
"
);
// Returns the promise so that ButtonWithStatus can show the saving status
return
this
.
props
.
updateRemappings
(
this
.
state
.
editingRemappings
);
}
...
...
@@ -451,7 +453,9 @@ export class FieldRemapping extends Component {
this
.
clearEditingStates
();
if
(
mappingType
.
type
===
"
original
"
)
{
MetabaseAnalytics
.
trackEvent
(
"
Data Model
"
,
"
Change Remapping Type
"
,
"
No Remapping
"
);
await
deleteFieldDimension
(
field
.
id
)
this
.
setState
({
hasChanged
:
false
})
}
else
if
(
mappingType
.
type
===
"
foreign
"
)
{
...
...
@@ -459,6 +463,7 @@ export class FieldRemapping extends Component {
const
entityNameFieldId
=
this
.
getFKTargetTableEntityNameOrNull
();
if
(
entityNameFieldId
)
{
MetabaseAnalytics
.
trackEvent
(
"
Data Model
"
,
"
Change Remapping Type
"
,
"
Foreign Key
"
);
await
updateFieldDimension
(
field
.
id
,
{
type
:
"
external
"
,
name
:
field
.
display_name
,
...
...
@@ -473,6 +478,7 @@ export class FieldRemapping extends Component {
}
}
else
if
(
mappingType
.
type
===
"
custom
"
)
{
MetabaseAnalytics
.
trackEvent
(
"
Data Model
"
,
"
Change Remapping Type
"
,
"
Custom Remappings
"
);
await
updateFieldDimension
(
field
.
id
,
{
type
:
"
internal
"
,
name
:
field
.
display_name
,
...
...
@@ -495,6 +501,7 @@ export class FieldRemapping extends Component {
// TODO Atte Keinänen 7/10/17: Use Dimension class when migrating to metabase-lib
if
(
foreignKeyClause
.
length
===
3
&&
foreignKeyClause
[
0
]
===
"
fk->
"
)
{
MetabaseAnalytics
.
trackEvent
(
"
Data Model
"
,
"
Update FK Remapping Target
"
);
await
updateFieldDimension
(
field
.
id
,
{
type
:
"
external
"
,
name
:
field
.
display_name
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment