Skip to content
Snippets Groups Projects
Unverified Commit f41e4eb6 authored by Nemanja Glumac's avatar Nemanja Glumac Committed by GitHub
Browse files

Simplify `openEntryForm` helper function (#16895)

- Simplifies openEntryForm helper function
- Fixes `frontend/test/metabase/scenarios/filters/sql-field-filter-string.cy.spec.js` and `frontend/test/metabase/scenarios/filters/sql-field-filter-number.cy.spec.js` logic.
parent 9b1d72e0
No related branches found
No related tags found
No related merge requests found
import { filterWidget, popover } from "__support__/e2e/cypress";
import { toggleRequired } from "./e2e-sql-filter-helpers";
// FILTER WIDGET TYPE
......@@ -87,13 +86,12 @@ export function mapTo({ table, field } = {}) {
}
/**
* Opens a field filter entry form. Entry type (input, picker) depends on the underlying field filter type.
* Opens a field filter entry form.
* Entry type that it opens (input, picker) depends on the underlying field filter type.
*
* @param {boolean} isFilterRequired
*/
export function openEntryForm(isFilterRequired) {
isFilterRequired && toggleRequired();
const selector = isFilterRequired
? cy.findByText("Enter a default value...")
: filterWidget();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment