fix(sdk): hide downloads by default (#48755)

* hide downloads by default in the sdk

* update readme to reflect withDownloads prop

* update readme formatting

* update tests

enterprise/frontend/src/embedding-sdk/README.md

@@ -437,7 +437,7 @@ After the SDK is configured, you can embed your dashboard using the `StaticDashb
   option, use a `string` value, and use a list of strings for multiple options.
 - **withTitle**: `boolean` – Whether the dashboard should display a title.
 - **withCardTitle**: `boolean` – Whether the dashboard cards should display a title.
-- **withDownloads**: `boolean | null` – Whether to hide the download button.
+- **withDownloads**: `boolean | null` – Whether to show the download button. Defaults to `false`.
 - **hiddenParameters**: `string[] | null` – A list of parameters that will not be shown in the set of parameter
   filters. [More information here](https://www.metabase.com/docs/latest/questions/sharing/public-links#filter-parameters)
 - **onLoad**: `(dashboard: Dashboard | null) => void;` - event handler that triggers after dashboard loads with all
@@ -488,7 +488,7 @@ After the SDK is configured, you can embed your dashboard using the `Interactive
   option, use a `string` value, and use a list of strings for multiple options.
 - **withTitle**: `boolean` – Whether the dashboard should display a title.
 - **withCardTitle**: `boolean` – Whether the dashboard cards should display a title.
-- **withDownloads**: `boolean | null` – Whether to hide the download button.
+- **withDownloads**: `boolean | null` – Whether to show the download button. Defaults to `false`.
 - **hiddenParameters**: `string[] | null` – A list of parameters that will not be shown in the set of parameter
   filters. (More information
   here)[https://www.metabase.com/docs/latest/questions/sharing/public-links#filter-parameters]
@@ -610,7 +610,7 @@ component.
       Collection Browser to return data
 - **initialParameterValues**: `Record<string, string | string[]>` – Query parameters for the dashboard. For a single
   option, use a `string` value, and use a list of strings for multiple options.
-- **withDownloads**: `boolean | null` – Whether to hide the download button.
+- **withDownloads**: `boolean | null` – Whether to show the download button. Defaults to `false`.
 - **questionHeight**: `number | null` – Height of a question component when drilled from the dashboard to a question
   level.
 - **plugins** `{ dashcardMenu?: Object, mapQuestionClickActions?: Function } | null` – Additional mapper function to
@@ -679,7 +679,7 @@ With the Collection Browser, you can browse the items in your Metabase instance
   in `http://localhost:3000/collection/1-my-collection` would be `1`. If no ID is provided, the collection browser will
   start at the root `Our analytics` collection, which is ID = 0.
 - **onClick**: `(item: CollectionItem) => void` - An optional click handler that emits the clicked entity.
-- **pageSize**: `number` – The number of items to display per page. The default is 25.
+- **pageSize**: `number` – The number of items to display per page. Defaults to 25.
 - **visibleEntityTypes**: `("question" | "model" | "dashboard" | "collection")[]` – the types of entities that should be
   visible. If not provided, all entities will be shown.
 

enterprise/frontend/src/embedding-sdk/components/public/InteractiveDashboard/EditableDashboard.tsx

@@ -30,7 +30,7 @@ export type EditableDashboardProps = {
 export const EditableDashboard = ({
   dashboardId,
   initialParameterValues = {},
-  withDownloads = true,
+  withDownloads = false,
   questionHeight,
   plugins,
   onLoad,

enterprise/frontend/src/embedding-sdk/components/public/InteractiveDashboard/InteractiveDashboard.tsx

@@ -34,7 +34,7 @@ const InteractiveDashboardInner = ({
   initialParameterValues = {},
   withTitle = true,
   withCardTitle = true,
-  withDownloads = true,
+  withDownloads = false,
   hiddenParameters = [],
   questionHeight,
   plugins,

enterprise/frontend/src/embedding-sdk/components/public/StaticDashboard/StaticDashboard.tsx

@@ -26,7 +26,7 @@ export const StaticDashboardInner = ({
   initialParameterValues = {},
   withTitle = true,
   withCardTitle = true,
-  withDownloads = true,
+  withDownloads = false,
   hiddenParameters = [],
   onLoad,
   onLoadWithoutCards,

enterprise/frontend/src/embedding-sdk/tests/sdk-locale-support.stories.tsx

@@ -10,6 +10,9 @@ export default {
 
 export const DeLocale = () => (
   <MetabaseProvider config={storybookSdkDefaultConfig} locale="de">
-    <StaticDashboard dashboardId={(window as any).DASHBOARD_ID || 1} />
+    <StaticDashboard
+      dashboardId={(window as any).DASHBOARD_ID || 1}
+      withDownloads
+    />
   </MetabaseProvider>
 );