Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
f4f2d45b
Unverified
Commit
f4f2d45b
authored
10 months ago
by
Cal Herries
Committed by
GitHub
10 months ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix connection impersonation when jdbc spec is passed (#43147)
parent
d208d800
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/driver/sql_jdbc/execute.clj
+10
-3
10 additions, 3 deletions
src/metabase/driver/sql_jdbc/execute.clj
with
10 additions
and
3 deletions
src/metabase/driver/sql_jdbc/execute.clj
+
10
−
3
View file @
f4f2d45b
...
...
@@ -348,9 +348,16 @@
(
log/tracef
"Setting default connection options with options %s"
(
pr-str
options
))
(
set-best-transaction-level!
driver
conn
)
(
set-time-zone-if-supported!
driver
conn
session-timezone
)
(
set-role-if-supported!
driver
conn
(
cond
(
integer?
db-or-id-or-spec
)
(
qp.store/with-metadata-provider
db-or-id-or-spec
(
lib.metadata/database
(
qp.store/metadata-provider
)))
(
u/id
db-or-id-or-spec
)
db-or-id-or-spec
))
(
when-let
[
db
(
cond
;; id?
(
integer?
db-or-id-or-spec
)
(
qp.store/with-metadata-provider
db-or-id-or-spec
(
lib.metadata/database
(
qp.store/metadata-provider
)))
;; db?
(
u/id
db-or-id-or-spec
)
db-or-id-or-spec
;; otherwise it's a spec and we can't get the db
:else
nil
)]
(
set-role-if-supported!
driver
conn
db
))
(
let
[
read-only?
(
not
write?
)]
(
try
;; Setting the connection to read-only does not prevent writes on some databases, and is meant
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment