-
- Downloads
Clean up dashboard URL management (#44639)
* Fix falsy tabSelected/tabRenamed checks * Update URL management (WIP) * Fix tests failing because of whitespace changes * Fix tests failing because of parameter order * Use one hook for parameters and tab URL management * Fix tests failing because of parameter order * Fix test failing because of whitespace changes * Revert * Fix DashboardTabs tests * Fix tests failing because of parameter order * Fix test * Fix test failing because of whitespace changes * Remove unit tests that should be e2e tests now * Fix tab navigation * Fix string encoding/decoding * Revert test changes * Consistent question search params * Update DashboardTabs tests * Fix `SyncedParametersList` * Fix e2e tests * Fix nav usage * Fix types * Remove `useSyncedQueryString` * Fix test * Move slug utils to dashboard utils * Fix nav * Revert nav change * Fix e2e tests * Fix public/embedded dashboards, handle site url * Add repro test * Bring back and fix `PublicOrEmbeddedDashboardPage` tests * Move `SyncedParametersList` to qb
Showing
- .eslintrc.js 1 addition, 1 deletion.eslintrc.js
- e2e/support/helpers/e2e-dashboard-helpers.js 1 addition, 1 deletione2e/support/helpers/e2e-dashboard-helpers.js
- e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js 82 additions, 9 deletionse2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js
- e2e/test/scenarios/dashboard-cards/dashboard-drill.cy.spec.js 1 addition, 1 deletion...test/scenarios/dashboard-cards/dashboard-drill.cy.spec.js
- e2e/test/scenarios/dashboard-filters/dashboard-filters-explicit-join.cy.spec.js 1 addition, 1 deletion...hboard-filters/dashboard-filters-explicit-join.cy.spec.js
- e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.js 4 additions, 4 deletions...hboard-filters/dashboard-filters-text-category.cy.spec.js
- e2e/test/scenarios/dashboard-filters/parameters.cy.spec.js 4 additions, 4 deletionse2e/test/scenarios/dashboard-filters/parameters.cy.spec.js
- e2e/test/scenarios/embedding/embedding-dashboard.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/embedding/embedding-dashboard.cy.spec.js
- e2e/test/scenarios/embedding/embedding-linked-filters.cy.spec.js 10 additions, 10 deletions...t/scenarios/embedding/embedding-linked-filters.cy.spec.js
- e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js 2 additions, 2 deletions...-reproductions/dashboard-filters-reproductions.cy.spec.js
- frontend/src/metabase/dashboard/components/DashboardParameterList/DashboardParameterList.tsx 5 additions, 15 deletions...ponents/DashboardParameterList/DashboardParameterList.tsx
- frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.unit.spec.tsx 23 additions, 7 deletions...oard/components/DashboardTabs/DashboardTabs.unit.spec.tsx
- frontend/src/metabase/dashboard/components/DashboardTabs/SyncedDashboardTabs.tsx 0 additions, 31 deletions...ashboard/components/DashboardTabs/SyncedDashboardTabs.tsx
- frontend/src/metabase/dashboard/components/DashboardTabs/use-sync-url-slug.ts 0 additions, 140 deletions...e/dashboard/components/DashboardTabs/use-sync-url-slug.ts
- frontend/src/metabase/dashboard/components/DashboardTabs/use-sync-url-slug.unit.spec.ts 0 additions, 46 deletions...d/components/DashboardTabs/use-sync-url-slug.unit.spec.ts
- frontend/src/metabase/dashboard/containers/AutomaticDashboardApp.jsx 16 additions, 4 deletions...c/metabase/dashboard/containers/AutomaticDashboardApp.jsx
- frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.tsx 11 additions, 4 deletions...tabase/dashboard/containers/DashboardApp/DashboardApp.tsx
- frontend/src/metabase/dashboard/hooks/index.ts 1 addition, 0 deletionsfrontend/src/metabase/dashboard/hooks/index.ts
- frontend/src/metabase/dashboard/hooks/use-dashboard-url-query.ts 138 additions, 0 deletions...d/src/metabase/dashboard/hooks/use-dashboard-url-query.ts
- frontend/src/metabase/dashboard/selectors.ts 63 additions, 5 deletionsfrontend/src/metabase/dashboard/selectors.ts
Loading
Please register or sign in to comment