Cover `Offset()` in aggregations with e2e tests (#42455)
* Add repro for 32323 * Fix offset not working in case * Make offset function return any * Add a repro for #42377 * Fix order of adjustments * Revert unrelated changes * Remove commented code * Revert unrelated changes * Refactor test * Type offset aggregation * Add a test for no order by or breakout clause * Add a basic test for breakout clause * Fix assertion * Remove problematic dependency * Fix uuids generation * Remove redundant limit * Add a test for multiple breakouts * Update test names * Extract OFFSET_SUM_TOTAL_AGGREGATION * Add a repro for metabase#42509 * Add a test for multiple aggregations and breakouts * Remove unused intercept * Move uuid utils to separate file - it wasn't possible to import the utils file in e2e tests without it * Make isUuid a type guard * Add tests for sorting * Tag the test * Add extra assertion to verify expression parsing * Add a complex scenario * Reverse isFirst logic
Showing
- e2e/test/scenarios/question/offset.cy.spec.ts 366 additions, 14 deletionse2e/test/scenarios/question/offset.cy.spec.ts
- frontend/src/metabase-types/api/query.ts 8 additions, 1 deletionfrontend/src/metabase-types/api/query.ts
- frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.jsx 1 addition, 1 deletion...admin/settings/components/widgets/CustomGeoJSONWidget.jsx
- frontend/src/metabase/dashboard/utils.ts 3 additions, 2 deletionsfrontend/src/metabase/dashboard/utils.ts
- frontend/src/metabase/lib/utils.ts 0 additions, 30 deletionsfrontend/src/metabase/lib/utils.ts
- frontend/src/metabase/lib/uuid.ts 29 additions, 0 deletionsfrontend/src/metabase/lib/uuid.ts
- frontend/src/metabase/query_builder/components/template_tags/TagEditorHelp/TagEditorHelp.tsx 1 addition, 1 deletion.../components/template_tags/TagEditorHelp/TagEditorHelp.tsx
- frontend/src/metabase/visualizations/visualizations/SmartScalar/SettingsComponents/SmartScalarSettingsWidgets.tsx 4 additions, 5 deletions...tScalar/SettingsComponents/SmartScalarSettingsWidgets.tsx
- frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.ts 1 addition, 1 deletion...tabase/visualizations/visualizations/SmartScalar/utils.ts
Loading
Please register or sign in to comment