-
- Downloads
Drill through fixes and cleanup (#11032)
* Full support for all dimension types in expression editor (field-id, field-literal, fk->, joined-field, expression) * Fix various bugs in metabase-lib * Limit 'card-has-ambiguous-columns?' to native queries + use real DB id in composeThisQuery * Fix and add to tests * Swap Question constructor metadata/card args + misc other cleanup * Refactor and fix drill-throughs to support explicit joins etc * Misc FE metadata code cleanup (#11044) * Fix joined dimension options, e.x. custom field from a saved query * Cleanup schema_metadata and related method names * Use shorter aggregate/filter/breakout/sort/join methods everywhere * Add UnderlyingRecordsDrill tests
Showing
- frontend/src/metabase-lib/lib/Dimension.js 51 additions, 39 deletionsfrontend/src/metabase-lib/lib/Dimension.js
- frontend/src/metabase-lib/lib/Question.js 28 additions, 36 deletionsfrontend/src/metabase-lib/lib/Question.js
- frontend/src/metabase-lib/lib/metadata/Field.js 9 additions, 9 deletionsfrontend/src/metabase-lib/lib/metadata/Field.js
- frontend/src/metabase-lib/lib/metadata/Table.js 3 additions, 3 deletionsfrontend/src/metabase-lib/lib/metadata/Table.js
- frontend/src/metabase-lib/lib/queries/StructuredQuery.js 24 additions, 15 deletionsfrontend/src/metabase-lib/lib/queries/StructuredQuery.js
- frontend/src/metabase-lib/lib/queries/structured/Aggregation.js 32 additions, 26 deletions...nd/src/metabase-lib/lib/queries/structured/Aggregation.js
- frontend/src/metabase-lib/lib/queries/structured/Breakout.js 1 addition, 1 deletionfrontend/src/metabase-lib/lib/queries/structured/Breakout.js
- frontend/src/metabase-lib/lib/queries/structured/Filter.js 12 additions, 12 deletionsfrontend/src/metabase-lib/lib/queries/structured/Filter.js
- frontend/src/metabase/admin/datamodel/components/PartialQueryBuilder.jsx 6 additions, 3 deletions...tabase/admin/datamodel/components/PartialQueryBuilder.jsx
- frontend/src/metabase/admin/datamodel/containers/MetricForm.jsx 5 additions, 5 deletions...nd/src/metabase/admin/datamodel/containers/MetricForm.jsx
- frontend/src/metabase/components/EntitySegments.jsx 1 addition, 1 deletionfrontend/src/metabase/components/EntitySegments.jsx
- frontend/src/metabase/containers/AdHocQuestionLoader.jsx 2 additions, 2 deletionsfrontend/src/metabase/containers/AdHocQuestionLoader.jsx
- frontend/src/metabase/containers/QuestionLoader.jsx 1 addition, 1 deletionfrontend/src/metabase/containers/QuestionLoader.jsx
- frontend/src/metabase/containers/SavedQuestionLoader.jsx 2 additions, 2 deletionsfrontend/src/metabase/containers/SavedQuestionLoader.jsx
- frontend/src/metabase/lib/expressions/index.js 2 additions, 2 deletionsfrontend/src/metabase/lib/expressions/index.js
- frontend/src/metabase/lib/expressions/parser.js 5 additions, 5 deletionsfrontend/src/metabase/lib/expressions/parser.js
- frontend/src/metabase/lib/query/field_ref.js 6 additions, 6 deletionsfrontend/src/metabase/lib/query/field_ref.js
- frontend/src/metabase/lib/schema_metadata.js 73 additions, 74 deletionsfrontend/src/metabase/lib/schema_metadata.js
- frontend/src/metabase/lib/table.js 7 additions, 4 deletionsfrontend/src/metabase/lib/table.js
- frontend/src/metabase/meta/types/Metadata.js 4 additions, 12 deletionsfrontend/src/metabase/meta/types/Metadata.js
Loading
Please register or sign in to comment