Clean up static chart components accessors (#20968)

* accessors constants created

* accessors dependencies removed from all charts

* Removed accessors dependencies from BE JS for static viz

* Removed accessors references in chart editor

* accessors added to defaultProps

* Remove accessors in tests

* defaultProps removed form static viz components

frontend/src/metabase/static-viz/containers/StaticChart/StaticChart.unit.spec.js

@@ -12,10 +12,6 @@ describe("StaticChart", () => {
             ["Gadget", 20],
             ["Widget", 31],
           ],
-          accessors: {
-            x: row => row[0],
-            y: row => row[1],
-          },
           settings: {
             y: {
               number_style: "currency",
@@ -46,10 +42,6 @@ describe("StaticChart", () => {
             ["Gadget", 20],
             ["Widget", 31],
           ],
-          accessors: {
-            x: row => row[0],
-            y: row => row[1],
-          },
           settings: {
             y: {
               number_style: "currency",
@@ -80,10 +72,6 @@ describe("StaticChart", () => {
             ["Gadget", 20],
             ["Widget", 31],
           ],
-          accessors: {
-            x: row => row[0],
-            y: row => row[1],
-          },
           settings: {
             y: {
               number_style: "currency",
@@ -118,10 +106,6 @@ describe("StaticChart", () => {
             donut: "#509EE3",
             cronut: "#DDECFA",
           },
-          accessors: {
-            dimension: row => row[0],
-            metric: row => row[1],
-          },
           settings: {
             metric: {
               number_style: "currency",
@@ -146,10 +130,6 @@ describe("StaticChart", () => {
             ["2010-11-07", 20],
             ["2020-11-08", 30],
           ],
-          accessors: {
-            x: row => new Date(row[0]).valueOf(),
-            y: row => row[1],
-          },
           settings: {
             x: {
               date_style: "dddd",
@@ -176,10 +156,6 @@ describe("StaticChart", () => {
             ["2010-11-07", 20],
             ["2020-11-08", 30],
           ],
-          accessors: {
-            x: row => new Date(row[0]).valueOf(),
-            y: row => row[1],
-          },
           settings: {
             x: {
               date_style: "MMM",
@@ -206,10 +182,6 @@ describe("StaticChart", () => {
             ["2010-11-07", 20],
             ["2020-11-08", 30],
           ],
-          accessors: {
-            x: row => new Date(row[0]).valueOf(),
-            y: row => row[1],
-          },
           settings: {
             x: {
               date_style: "dddd",

frontend/src/metabase/static-viz/lib/waterfall.unit.spec.js

+import { POSITIONAL_ACCESSORS } from "../constants/accessors";
 import { calculateWaterfallEntries } from "./waterfall";
 
-const accessors = {
-  x: row => row[0],
-  y: row => row[1],
-};
-
 describe("calculateWaterfallEntries", () => {
   it("calculates waterfall entries without total", () => {
     const data = [
@@ -12,7 +8,11 @@ describe("calculateWaterfallEntries", () => {
       ["2", -50],
       ["3", 10],
     ];
-    const entries = calculateWaterfallEntries(data, accessors, false);
+    const entries = calculateWaterfallEntries(
+      data,
+      POSITIONAL_ACCESSORS,
+      false,
+    );
 
     expect(entries).toStrictEqual([
       {
@@ -42,7 +42,7 @@ describe("calculateWaterfallEntries", () => {
       ["2", -50],
       ["3", 10],
     ];
-    const entries = calculateWaterfallEntries(data, accessors, true);
+    const entries = calculateWaterfallEntries(data, POSITIONAL_ACCESSORS, true);
 
     expect(entries).toStrictEqual([
       {
@@ -79,7 +79,7 @@ describe("calculateWaterfallEntries", () => {
       ["2", -200],
       ["3", 50],
     ];
-    const entries = calculateWaterfallEntries(data, accessors, true);
+    const entries = calculateWaterfallEntries(data, POSITIONAL_ACCESSORS, true);
 
     expect(entries).toStrictEqual([
       {

resources/frontend_shared/static_viz_interface.js

@@ -14,26 +14,10 @@ function toJSMap(m) {
   return o;
 }
 
-const date_accessors = {
-  x: row => new Date(row[0]).valueOf(),
-  y: row => row[1],
-};
-
-const positional_accessors = {
-  x: row => row[0],
-  y: row => row[1],
-};
-
-const dimension_accessors = {
-  dimension: row => row[0],
-  metric: row => row[1],
-};
-
 function timeseries_line(data, labels, settings) {
   return StaticViz.RenderChart("timeseries/line", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: date_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -42,7 +26,6 @@ function timeseries_bar(data, labels, settings) {
   return StaticViz.RenderChart("timeseries/bar", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: date_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -51,7 +34,6 @@ function timeseries_area(data, labels, settings) {
   return StaticViz.RenderChart("timeseries/area", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: date_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -69,7 +51,6 @@ function timeseries_waterfall(data, labels, settings) {
   return StaticViz.RenderChart("timeseries/waterfall", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: date_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -85,7 +66,6 @@ function categorical_bar(data, labels, settings) {
   return StaticViz.RenderChart("categorical/bar", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: positional_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -94,7 +74,6 @@ function categorical_area(data, labels, settings) {
   return StaticViz.RenderChart("categorical/area", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: positional_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -103,7 +82,6 @@ function categorical_line(data, labels, settings) {
   return StaticViz.RenderChart("categorical/line", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: positional_accessors,
     settings: JSON.parse(settings),
   });
 }
@@ -112,7 +90,6 @@ function categorical_donut(rows, colors) {
   return StaticViz.RenderChart("categorical/donut", {
     data: toJSArray(rows),
     colors: toJSMap(colors),
-    accessors: dimension_accessors,
   });
 }
 
@@ -120,7 +97,6 @@ function categorical_waterfall(data, labels, settings) {
   return StaticViz.RenderChart("categorical/waterfall", {
     data: toJSArray(data),
     labels: toJSMap(labels),
-    accessors: positional_accessors,
     settings: JSON.parse(settings),
   });
 }