-
- Downloads
Previous period comparison shortcut in chill mode - column headers (#43500)
* Sort functions
* Add boilerplate for aggregateOffset and tests
* Simplify assertion
* Make basic case work
* Handle name generation
* Do not require "lib/uuid" attribute to be present since MLv2 will normalize it under the hood anyway
* Fix typing
* Group tests
* Refactor offsetClause to return a new clause instead of a new query
- Move offsetClause to expressions.ts
- Add assertion
* Revert "Sort functions"
This reverts commit ab9ce2b24ea6bdad5ff7e9bed8ef38d4b5923f00.
* Move tests
* Handle names dynamically
* Shorten a test
* Update comment
* Add TODO
* Update expression types
* Add diffOffsetClause & percentDiffOffsetClause
* Add a test for diffOffsetClause
* Add TODOs
* Add tests for diffOffsetClause and percentDiffOffsetClause
* Unwrap tests
* Add skeleton for new tests
* Refactor first offsetClause tests
* Add tests for names
* Fix case of non-datetime columns
* Handle a case with offset < 1 and no breakouts
* Handle a case with offset < 1 and breakouts on non-datetime column
* Handle a case with offset < 1 and breakouts binned datetime column
* Handle a case with offset < 1 and breakout on non-binned datetime column
* Refactor
* Refactor
* Remove TODO
* Add tests for diffOffsetClause
* Add tests for percentDiffOffsetClause
* Move offset stuff to offset.ts and offset.unit.spec.ts
* Use template string for prefixes
* Use breakoutColumn + isDate to check column type
* Refactor
* Fix error message
* Add boilerplate for CompareAggregations
* Fix title
* Render aggregations list
* Style AccordionList
* Sort props
* Fix bucket name
* Use displayName instead shortName
* Support parseValue prop in NumberInput
* Add period input accepting integers only
* Accept non-negative values only
* Do not accept zeros
* Add state
* Add submit button
* Export offset functions via Lib
* Make it possible to skip rightSection
* Add column picker
* Map offset user input to api input (negative value)
* Add label
* Fix crash
* Extract shouldCreate
* Make onSelect in AggregationPicker support multiple values
* Extract ReferenceAggregationPicker
* Extract ColumnPicker
* Extract getAggregations
* Rename
* Add custom items
* Refactor item component
* Extract OffsetInput
* Remove unused data-testid
* Style OffsetInput
* Generate titles according to specs
* Generate label
* Generate help
* Extract utils
* Use different width for the 1st step
* Format code
* Use MultiSelect directly
* Avoid custom parseValue
* Revert MultiaAutocomplete changes
* Improve typing in describeTemporalInterval and
describeRelativeDatetime
* Use describeTemporalUnit to pluralize
* Use interface
* Avoid setting value as DOM attribute
* Fix test
* Add onAdd prop to AggregationPicker and revert the change to have onSelect pass multiple aggregations
* Reduce number of props
* Render checkboxes in custom items
* Introduce and use --mb-color-brand-lighter
* Avoid !important
* Remove redundant prop
* Rename ExtractColumn to ExtractColumnAction
* Add lines.svg
* Fix positioning in case dir attribute is not present in any parent component
* Add CompareAggregationsAction
* Fix warning about isSelected being used as DOM attribute
* Fix positioning in case dir attribute is not present in any parent component
* Remove redundant Box
* Compute the title
* Add compareAggregationsDrill boilerplate
* Add compare-aggregations drill stub
* Update comment
* Compute title and aggregation
* Add TODO
* Use proper title when there's only 1 aggregation
* Show visualization on submit
* Limit aggregation choice to 1 in compare aggregations drill
* Redirect to chart upon submission
* Do not navigate to chart view
* Do not navigate to chart view
* Make drill-thru tests expect the new compare-aggregations drill
* Add type attribute to all ListItems
* Add aggregationIndex to drillInfo
* Add aggregationDrillDetails and wire it up
* Fix destructuring
* Fix tests
---------
Co-authored-by:
Braden Shepherdson <braden@metabase.com>
Showing
- frontend/src/metabase-lib/drills.ts 7 additions, 0 deletionsfrontend/src/metabase-lib/drills.ts
- frontend/src/metabase-lib/types.ts 9 additions, 0 deletionsfrontend/src/metabase-lib/types.ts
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.tsx 17 additions, 5 deletions...common/components/AggregationPicker/AggregationPicker.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.tsx 3 additions, 4 deletions...er/components/CompareAggregations/CompareAggregations.tsx
- frontend/src/metabase/querying/utils/drills/compare-aggregations-drill/compare-aggregations-drill.tsx 62 additions, 0 deletions...compare-aggregations-drill/compare-aggregations-drill.tsx
- frontend/src/metabase/querying/utils/drills/compare-aggregations-drill/index.ts 1 addition, 0 deletions...querying/utils/drills/compare-aggregations-drill/index.ts
- frontend/src/metabase/querying/utils/drills/constants.ts 2 additions, 0 deletionsfrontend/src/metabase/querying/utils/drills/constants.ts
- frontend/src/metabase/visualizations/click-actions/actions/CompareAggregationsAction/CompareAggregationsAction.tsx 2 additions, 1 deletion...s/CompareAggregationsAction/CompareAggregationsAction.tsx
- frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts 1 addition, 0 deletions...se/visualizations/click-actions/modes/EmbeddingSdkMode.ts
- frontend/src/metabase/visualizations/components/ClickActions/utils.ts 1 addition, 0 deletions.../metabase/visualizations/components/ClickActions/utils.ts
- frontend/src/metabase/visualizations/types/click-actions.ts 1 addition, 0 deletionsfrontend/src/metabase/visualizations/types/click-actions.ts
- src/metabase/lib/drill_thru.cljc 2 additions, 0 deletionssrc/metabase/lib/drill_thru.cljc
- src/metabase/lib/drill_thru/compare_aggregations.cljc 33 additions, 0 deletionssrc/metabase/lib/drill_thru/compare_aggregations.cljc
- src/metabase/lib/js.cljs 12 additions, 0 deletionssrc/metabase/lib/js.cljs
- src/metabase/lib/schema/drill_thru.cljc 9 additions, 0 deletionssrc/metabase/lib/schema/drill_thru.cljc
- test/metabase/lib/drill_thru_test.cljc 15 additions, 2 deletionstest/metabase/lib/drill_thru_test.cljc
Loading
Please register or sign in to comment