Skip to content
Snippets Groups Projects
Commit f6899e7c authored by Allen Gilliland's avatar Allen Gilliland
Browse files

Merge pull request #556 from metabase/pie_chart_nulls

Handle nulls in pie, line, and bar charts
parents fac94197 524babbd
No related branches found
No related tags found
No related merge requests found
......@@ -311,9 +311,10 @@ function applyChartOrdinalXAxis(chart, card, coldefs, data, minPixelsPerTick) {
xAxis.tickValues(visibleKeys);
}
xAxis.tickFormat((d) => d == null ? '[unset]' : d);
} else {
xAxis.ticks(0);
xAxis.tickFormat(function(d) { return ""; });
xAxis.tickFormat('');
}
chart.x(d3.scale.ordinal().domain(keys))
......@@ -799,6 +800,9 @@ export var CardRenderer = {
var index = _.indexOf(keys, d.key);
return settings.pie.colors[index % settings.pie.colors.length];
})
.label(function(row) {
return row.key == null ? '[unset]' : row.key;
})
.title(function(d) {
// ghetto rounding to 1 decimal digit since Math.round() doesn't let
// you specify a precision and always rounds to int
......@@ -806,6 +810,8 @@ export var CardRenderer = {
return d.key + ': ' + d.value + ' (' + percent + '%)';
});
// disables ability to select slices
chart.filter = function() {};
applyChartTooltips(chart, card, result.cols);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment