Delete MetaBot permissions group (#20925)

resources/migrations/000_migrations.yaml

@@ -11238,6 +11238,14 @@ databaseChangeLog:
                     AND db.object = p.object
               WHERE p.object IS NULL;
 
+  - changeSet:
+      id: v43.00-044
+      author: noahmoss
+      comment: Added 0.43.0 - Removes MetaBot permissions group
+      changes:
+        - sql:
+            sql: DELETE FROM permissions_group WHERE name = 'MetaBot'
+
 # >>>>>>>>>> DO NOT ADD NEW MIGRATIONS BELOW THIS LINE! ADD THEM ABOVE <<<<<<<<<<
 
 ########################################################################################################################

src/metabase/models/permissions.clj

@@ -666,12 +666,11 @@
   See [[metabase.models.collection.graph]] for the Collection permissions graph code."
   []
   (let [permissions     (db/select [Permissions [:group_id :group-id] [:object :path]]
-                                   {:where [:and
-                                            [:or
-                                             [:= :object (hx/literal "/")]
-                                             [:like :object (hx/literal "/db/%")]
-                                             [:like :object (hx/literal "/download/%")]
-                                             [:like :object (hx/literal "/block/db/%")]]]})
+                                   {:where [:or
+                                            [:= :object (hx/literal "/")]
+                                            [:like :object (hx/literal "/db/%")]
+                                            [:like :object (hx/literal "/download/%")]
+                                            [:like :object (hx/literal "/block/db/%")]]})
         db-ids          (delay (db/select-ids 'Database))
         group-id->paths (reduce
                          (fn [m {:keys [group-id path]}]

src/metabase/models/permissions_group.clj

@@ -40,7 +40,7 @@
   "All Users")
 
 (def ^{:arglists '([])} all-users
-  "Fetch the `All Users` permissions group, creating it if needed."
+  "Fetch the `All Users` permissions group"
   (magic-group all-users-group-name))
 
 (def admin-group-name
@@ -48,7 +48,7 @@
   "Administrators")
 
 (def ^{:arglists '([])} admin
-  "Fetch the `Administrators` permissions group, creating it if needed."
+  "Fetch the `Administrators` permissions group"
   (magic-group admin-group-name))