Remove broken field ref comparison with QP columns (#39517)

frontend/src/metabase-lib/comparison.ts

 import * as ML from "cljs/metabase.lib.js";
-import type {
-  DatasetColumn,
-  DatasetQuery,
-  DimensionReference,
-} from "metabase-types/api";
+import type { DatasetQuery, DimensionReference } from "metabase-types/api";
 
 import type { ColumnMetadata, Query } from "./types";
 
@@ -27,7 +23,7 @@ export function findMatchingColumn(
 export function findColumnIndexesFromLegacyRefs(
   query: Query,
   stageIndex: number,
-  columns: ColumnMetadata[] | DatasetColumn[],
+  columns: ColumnMetadata[],
   fieldRefs: DimensionReference[],
 ): number[] {
   return ML.find_column_indexes_from_legacy_refs(

frontend/src/metabase-lib/comparison.unit.spec.ts

-import { freeze } from "immer";
-
-import * as Lib from "metabase-lib";
-import { createQuery } from "metabase-lib/test-helpers";
-import {
-  createOrdersTaxDatasetColumn,
-  createOrdersTotalDatasetColumn,
-} from "metabase-types/api/mocks/presets";
-
-describe("findColumnIndexesFromLegacyRefs", () => {
-  it("works even on frozen columns and refs", () => {
-    const query = createQuery();
-    const stageIndex = -1;
-    const columns = freeze(
-      [createOrdersTotalDatasetColumn(), createOrdersTaxDatasetColumn()],
-      true,
-    );
-
-    const columnIndexes = Lib.findColumnIndexesFromLegacyRefs(
-      query,
-      stageIndex,
-      columns,
-      columns.map(({ field_ref }) => field_ref!),
-    );
-
-    expect(Object.isFrozen(columns[0])).toBe(true);
-    expect(Object.isFrozen(columns[1])).toBe(true);
-    expect(columnIndexes).toEqual([0, 1]);
-  });
-});